Skip to content

Commit 3700dc9

Browse files
committed
Merge tag 'ata-6.12-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux
Pull ata fixes from Niklas Cassel: - Fix a hibernate regression where the disk was needlessly spun down and then immediately spun up both when entering and when resuming from hibernation (me) - Update the MAINTAINERS file to remove remnants from Jens maintainership of libata (Damien) * tag 'ata-6.12-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux: ata: libata: Update MAINTAINERS file ata: libata: avoid superfluous disk spin down + spin up during hibernation
2 parents befcc89 + 0df4b9d commit 3700dc9

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

MAINTAINERS

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12944,7 +12944,6 @@ LIBATA PATA ARASAN COMPACT FLASH CONTROLLER
1294412944
M: Viresh Kumar <[email protected]>
1294512945
1294612946
S: Maintained
12947-
T: git git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
1294812947
F: drivers/ata/pata_arasan_cf.c
1294912948
F: include/linux/pata_arasan_cf_data.h
1295012949

@@ -12958,17 +12957,14 @@ LIBATA PATA FARADAY FTIDE010 AND GEMINI SATA BRIDGE DRIVERS
1295812957
M: Linus Walleij <[email protected]>
1295912958
1296012959
S: Maintained
12961-
T: git git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
1296212960
F: drivers/ata/pata_ftide010.c
1296312961
F: drivers/ata/sata_gemini.c
1296412962
F: drivers/ata/sata_gemini.h
1296512963

1296612964
LIBATA SATA AHCI PLATFORM devices support
1296712965
M: Hans de Goede <[email protected]>
12968-
M: Jens Axboe <[email protected]>
1296912966
1297012967
S: Maintained
12971-
T: git git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
1297212968
F: drivers/ata/ahci_platform.c
1297312969
F: drivers/ata/libahci_platform.c
1297412970
F: include/linux/ahci_platform.h
@@ -12977,7 +12973,6 @@ LIBATA SATA AHCI SYNOPSYS DWC CONTROLLER DRIVER
1297712973
M: Serge Semin <[email protected]>
1297812974
1297912975
S: Maintained
12980-
T: git git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git
1298112976
F: Documentation/devicetree/bindings/ata/baikal,bt1-ahci.yaml
1298212977
F: Documentation/devicetree/bindings/ata/snps,dwc-ahci.yaml
1298312978
F: drivers/ata/ahci_dwc.c
@@ -12986,7 +12981,6 @@ LIBATA SATA PROMISE TX2/TX4 CONTROLLER DRIVER
1298612981
M: Mikael Pettersson <[email protected]>
1298712982
1298812983
S: Maintained
12989-
T: git git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
1299012984
F: drivers/ata/sata_promise.*
1299112985

1299212986
LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)

drivers/ata/libata-eh.c

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4099,10 +4099,20 @@ static void ata_eh_handle_port_suspend(struct ata_port *ap)
40994099

41004100
WARN_ON(ap->pflags & ATA_PFLAG_SUSPENDED);
41014101

4102-
/* Set all devices attached to the port in standby mode */
4103-
ata_for_each_link(link, ap, HOST_FIRST) {
4104-
ata_for_each_dev(dev, link, ENABLED)
4105-
ata_dev_power_set_standby(dev);
4102+
/*
4103+
* We will reach this point for all of the PM events:
4104+
* PM_EVENT_SUSPEND (if runtime pm, PM_EVENT_AUTO will also be set)
4105+
* PM_EVENT_FREEZE, and PM_EVENT_HIBERNATE.
4106+
*
4107+
* We do not want to perform disk spin down for PM_EVENT_FREEZE.
4108+
* (Spin down will be performed by the subsequent PM_EVENT_HIBERNATE.)
4109+
*/
4110+
if (!(ap->pm_mesg.event & PM_EVENT_FREEZE)) {
4111+
/* Set all devices attached to the port in standby mode */
4112+
ata_for_each_link(link, ap, HOST_FIRST) {
4113+
ata_for_each_dev(dev, link, ENABLED)
4114+
ata_dev_power_set_standby(dev);
4115+
}
41064116
}
41074117

41084118
/*

0 commit comments

Comments
 (0)