Skip to content

Commit 3741f5f

Browse files
Naveenaidubjorn-helgaas
authored andcommitted
PCI: rcar-host: Drop error data fabrication when config read fails
If config pci_ops.read() methods return failure, the PCI_OP_READ() and PCI_USER_READ_CONFIG() wrappers use PCI_SET_ERROR_RESPONSE() to set the data value, so there's no need to set it in the pci_ops.read() methods themselves. Drop the unnecessary data value fabrication when pci_ops.read() fails. Link: https://lore.kernel.org/r/83540eb3ae76a0d28bbe03d69d685a6d549b456b.1637243717.git.naveennaidu479@gmail.com Signed-off-by: Naveen Naidu <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> Reviewed-by: Geert Uytterhoeven <[email protected]>
1 parent 5f09342 commit 3741f5f

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/pci/controller/pcie-rcar-host.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,10 +159,8 @@ static int rcar_pcie_read_conf(struct pci_bus *bus, unsigned int devfn,
159159

160160
ret = rcar_pcie_config_access(host, RCAR_PCI_ACCESS_READ,
161161
bus, devfn, where, val);
162-
if (ret != PCIBIOS_SUCCESSFUL) {
163-
*val = 0xffffffff;
162+
if (ret != PCIBIOS_SUCCESSFUL)
164163
return ret;
165-
}
166164

167165
if (size == 1)
168166
*val = (*val >> (BITS_PER_BYTE * (where & 3))) & 0xff;

0 commit comments

Comments
 (0)