Skip to content

Commit 37bbffc

Browse files
committed
firmware: arm_scmi: Remove extra check for invalid length message responses
scmi_xfer_get_init ensures both transmit and receive buffer lengths are within the maximum limits. If receive buffer length is not supplied by the caller, it's set to the maximum limit value. Receive buffer length is never modified after that. So there's no need for the extra check when receive transmit completion for a command essage. Further, if the response header length is greater than the prescribed receive buffer length, the response buffer is truncated to the latter. Reported-by: Jim Quinlan <[email protected]> Signed-off-by: Sudeep Holla <[email protected]>
1 parent 9eefa43 commit 37bbffc

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/firmware/arm_scmi/driver.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -230,12 +230,6 @@ static void scmi_rx_callback(struct mbox_client *cl, void *m)
230230
xfer = &minfo->xfer_block[xfer_id];
231231

232232
scmi_dump_header_dbg(dev, &xfer->hdr);
233-
/* Is the message of valid length? */
234-
if (xfer->rx.len > info->desc->max_msg_size) {
235-
dev_err(dev, "unable to handle %zu xfer(max %d)\n",
236-
xfer->rx.len, info->desc->max_msg_size);
237-
return;
238-
}
239233

240234
scmi_fetch_response(xfer, mem);
241235
complete(&xfer->done);

0 commit comments

Comments
 (0)