Skip to content

Commit 37d4159

Browse files
jankaraamschuma-ntap
authored andcommitted
nfs: Drop pointless check from nfs_commit_release_pages()
nfss->writeback is updated only when we are ending page writeback and at that moment we also clear nfss->write_congested. So there's no point in rechecking congestion state in nfs_commit_release_pages(). Drop the pointless check. Reviewed-by: Sagi Grimberg <[email protected]> Reviewed-by: Jeff Layton <[email protected]> Signed-off-by: Jan Kara <[email protected]> Signed-off-by: Anna Schumaker <[email protected]>
1 parent 7d09d6b commit 37d4159

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

fs/nfs/write.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1846,7 +1846,6 @@ static void nfs_commit_release_pages(struct nfs_commit_data *data)
18461846
struct nfs_page *req;
18471847
int status = data->task.tk_status;
18481848
struct nfs_commit_info cinfo;
1849-
struct nfs_server *nfss;
18501849
struct folio *folio;
18511850

18521851
while (!list_empty(&data->pages)) {
@@ -1889,9 +1888,6 @@ static void nfs_commit_release_pages(struct nfs_commit_data *data)
18891888
/* Latency breaker */
18901889
cond_resched();
18911890
}
1892-
nfss = NFS_SERVER(data->inode);
1893-
if (atomic_long_read(&nfss->writeback) < NFS_CONGESTION_OFF_THRESH)
1894-
nfss->write_congested = 0;
18951891

18961892
nfs_init_cinfo(&cinfo, data->inode, data->dreq);
18971893
nfs_commit_end(cinfo.mds);

0 commit comments

Comments
 (0)