Skip to content

Commit 383451c

Browse files
mchetankumarkuba-moo
authored andcommitted
net: wwan: iosm: fixes unable to send AT command during mbim tx
ev_cdev_write_pending flag is preventing a TX message post for AT port while MBIM transfer is ongoing. Removed the unnecessary check around control port TX transfer. Signed-off-by: M Chetan Kumar <[email protected]> Reviewed-by: Sergey Ryazanov <[email protected]> Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 07d3f27 commit 383451c

File tree

3 files changed

+0
-10
lines changed

3 files changed

+0
-10
lines changed

drivers/net/wwan/iosm/iosm_ipc_imem.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1270,7 +1270,6 @@ struct iosm_imem *ipc_imem_init(struct iosm_pcie *pcie, unsigned int device_id,
12701270

12711271
ipc_imem->pci_device_id = device_id;
12721272

1273-
ipc_imem->ev_cdev_write_pending = false;
12741273
ipc_imem->cp_version = 0;
12751274
ipc_imem->device_sleep = IPC_HOST_SLEEP_ENTER_SLEEP;
12761275

drivers/net/wwan/iosm/iosm_ipc_imem.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -336,8 +336,6 @@ enum ipc_phase {
336336
* process the irq actions.
337337
* @flag: Flag to monitor the state of driver
338338
* @td_update_timer_suspended: if true then td update timer suspend
339-
* @ev_cdev_write_pending: 0 means inform the IPC tasklet to pass
340-
* the accumulated uplink buffers to CP.
341339
* @ev_mux_net_transmit_pending:0 means inform the IPC tasklet to pass
342340
* @reset_det_n: Reset detect flag
343341
* @pcie_wake_n: Pcie wake flag
@@ -375,7 +373,6 @@ struct iosm_imem {
375373
u8 ev_irq_pending[IPC_IRQ_VECTORS];
376374
unsigned long flag;
377375
u8 td_update_timer_suspended:1,
378-
ev_cdev_write_pending:1,
379376
ev_mux_net_transmit_pending:1,
380377
reset_det_n:1,
381378
pcie_wake_n:1;

drivers/net/wwan/iosm/iosm_ipc_imem_ops.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ void ipc_imem_sys_wwan_close(struct iosm_imem *ipc_imem, int if_id,
4141
static int ipc_imem_tq_cdev_write(struct iosm_imem *ipc_imem, int arg,
4242
void *msg, size_t size)
4343
{
44-
ipc_imem->ev_cdev_write_pending = false;
4544
ipc_imem_ul_send(ipc_imem);
4645

4746
return 0;
@@ -50,11 +49,6 @@ static int ipc_imem_tq_cdev_write(struct iosm_imem *ipc_imem, int arg,
5049
/* Through tasklet to do sio write. */
5150
static int ipc_imem_call_cdev_write(struct iosm_imem *ipc_imem)
5251
{
53-
if (ipc_imem->ev_cdev_write_pending)
54-
return -1;
55-
56-
ipc_imem->ev_cdev_write_pending = true;
57-
5852
return ipc_task_queue_send_task(ipc_imem, ipc_imem_tq_cdev_write, 0,
5953
NULL, 0, false);
6054
}

0 commit comments

Comments
 (0)