Skip to content

Commit 388d8bd

Browse files
gormanmrostedt
authored andcommitted
tracing: Remove obsolete PREEMPTIRQ_EVENTS kconfig option
The PREEMPTIRQ_EVENTS option is unused after commit c3bc8fd ("tracing: Centralize preemptirq tracepoints and unify their usage"). Remove it. Note that this option is hazardous as it stands. It enables TRACE_IRQFLAGS event on non-preempt configurations without the irqsoff tracer enabled. TRACE_IRQFLAGS as it stands incurs significant overhead on each IRQ entry/exit. This is because trace_hardirqs_[on|off] does all the per-cpu manipulations and NMI checks even if tracing is completely disabled for some insane reason. For example, netperf running UDP_STREAM on localhost incurs a 4-6% performance penalty without any tracing if IRQFLAGS is set. It can be put behind a static brach but even the function entry/exit costs a little bit. Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Mel Gorman <[email protected]> Signed-off-by: Steven Rostedt (VMware) <[email protected]>
1 parent daceabf commit 388d8bd

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

kernel/trace/Kconfig

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -258,15 +258,6 @@ config TRACE_PREEMPT_TOGGLE
258258
Enables hooks which will be called when preemption is first disabled,
259259
and last enabled.
260260

261-
config PREEMPTIRQ_EVENTS
262-
bool "Enable trace events for preempt and irq disable/enable"
263-
select TRACE_IRQFLAGS
264-
select TRACE_PREEMPT_TOGGLE if PREEMPTION
265-
select GENERIC_TRACER
266-
default n
267-
help
268-
Enable tracing of disable and enable events for preemption and irqs.
269-
270261
config IRQSOFF_TRACER
271262
bool "Interrupts-off Latency Tracer"
272263
default n

0 commit comments

Comments
 (0)