Skip to content

Commit 38f8ccd

Browse files
committed
Merge tag 'mm-hotfixes-stable-2023-02-17-15-16-2' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Pull misc fixes from Andrew Morton: "Six hotfixes. Five are cc:stable: four for MM, one for nilfs2. Also a MAINTAINERS update" * tag 'mm-hotfixes-stable-2023-02-17-15-16-2' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm: nilfs2: fix underflow in second superblock position calculations hugetlb: check for undefined shift on 32 bit architectures mm/migrate: fix wrongly apply write bit after mkdirty on sparc64 MAINTAINERS: update FPU EMULATOR web page mm/MADV_COLLAPSE: set EAGAIN on unexpected page refcount mm/filemap: fix page end in filemap_get_read_batch
2 parents dbeed98 + 99b9402 commit 38f8ccd

File tree

9 files changed

+38
-7
lines changed

9 files changed

+38
-7
lines changed

MAINTAINERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8202,7 +8202,7 @@ F: drivers/fpga/microchip-spi.c
82028202
FPU EMULATOR
82038203
M: Bill Metzenthen <[email protected]>
82048204
S: Maintained
8205-
W: http://floatingpoint.sourceforge.net/emulator/index.html
8205+
W: https://floatingpoint.billm.au/
82068206
F: arch/x86/math-emu/
82078207

82088208
FRAMEBUFFER CORE

fs/nilfs2/ioctl.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1114,7 +1114,14 @@ static int nilfs_ioctl_set_alloc_range(struct inode *inode, void __user *argp)
11141114

11151115
minseg = range[0] + segbytes - 1;
11161116
do_div(minseg, segbytes);
1117+
1118+
if (range[1] < 4096)
1119+
goto out;
1120+
11171121
maxseg = NILFS_SB2_OFFSET_BYTES(range[1]);
1122+
if (maxseg < segbytes)
1123+
goto out;
1124+
11181125
do_div(maxseg, segbytes);
11191126
maxseg--;
11201127

fs/nilfs2/super.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -408,6 +408,15 @@ int nilfs_resize_fs(struct super_block *sb, __u64 newsize)
408408
if (newsize > devsize)
409409
goto out;
410410

411+
/*
412+
* Prevent underflow in second superblock position calculation.
413+
* The exact minimum size check is done in nilfs_sufile_resize().
414+
*/
415+
if (newsize < 4096) {
416+
ret = -ENOSPC;
417+
goto out;
418+
}
419+
411420
/*
412421
* Write lock is required to protect some functions depending
413422
* on the number of segments, the number of reserved segments,

fs/nilfs2/the_nilfs.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -544,9 +544,15 @@ static int nilfs_load_super_block(struct the_nilfs *nilfs,
544544
{
545545
struct nilfs_super_block **sbp = nilfs->ns_sbp;
546546
struct buffer_head **sbh = nilfs->ns_sbh;
547-
u64 sb2off = NILFS_SB2_OFFSET_BYTES(bdev_nr_bytes(nilfs->ns_bdev));
547+
u64 sb2off, devsize = bdev_nr_bytes(nilfs->ns_bdev);
548548
int valid[2], swp = 0;
549549

550+
if (devsize < NILFS_SEG_MIN_BLOCKS * NILFS_MIN_BLOCK_SIZE + 4096) {
551+
nilfs_err(sb, "device size too small");
552+
return -EINVAL;
553+
}
554+
sb2off = NILFS_SB2_OFFSET_BYTES(devsize);
555+
550556
sbp[0] = nilfs_read_super_block(sb, NILFS_SB_OFFSET_BYTES, blocksize,
551557
&sbh[0]);
552558
sbp[1] = nilfs_read_super_block(sb, sb2off, blocksize, &sbh[1]);

include/linux/hugetlb.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -743,7 +743,10 @@ static inline struct hstate *hstate_sizelog(int page_size_log)
743743
if (!page_size_log)
744744
return &default_hstate;
745745

746-
return size_to_hstate(1UL << page_size_log);
746+
if (page_size_log < BITS_PER_LONG)
747+
return size_to_hstate(1UL << page_size_log);
748+
749+
return NULL;
747750
}
748751

749752
static inline struct hstate *hstate_vma(struct vm_area_struct *vma)

mm/filemap.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2588,18 +2588,19 @@ static int filemap_get_pages(struct kiocb *iocb, struct iov_iter *iter,
25882588
struct folio *folio;
25892589
int err = 0;
25902590

2591+
/* "last_index" is the index of the page beyond the end of the read */
25912592
last_index = DIV_ROUND_UP(iocb->ki_pos + iter->count, PAGE_SIZE);
25922593
retry:
25932594
if (fatal_signal_pending(current))
25942595
return -EINTR;
25952596

2596-
filemap_get_read_batch(mapping, index, last_index, fbatch);
2597+
filemap_get_read_batch(mapping, index, last_index - 1, fbatch);
25972598
if (!folio_batch_count(fbatch)) {
25982599
if (iocb->ki_flags & IOCB_NOIO)
25992600
return -EAGAIN;
26002601
page_cache_sync_readahead(mapping, ra, filp, index,
26012602
last_index - index);
2602-
filemap_get_read_batch(mapping, index, last_index, fbatch);
2603+
filemap_get_read_batch(mapping, index, last_index - 1, fbatch);
26032604
}
26042605
if (!folio_batch_count(fbatch)) {
26052606
if (iocb->ki_flags & (IOCB_NOWAIT | IOCB_WAITQ))

mm/huge_memory.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3272,15 +3272,17 @@ void remove_migration_pmd(struct page_vma_mapped_walk *pvmw, struct page *new)
32723272
pmde = mk_huge_pmd(new, READ_ONCE(vma->vm_page_prot));
32733273
if (pmd_swp_soft_dirty(*pvmw->pmd))
32743274
pmde = pmd_mksoft_dirty(pmde);
3275-
if (is_writable_migration_entry(entry))
3276-
pmde = maybe_pmd_mkwrite(pmde, vma);
32773275
if (pmd_swp_uffd_wp(*pvmw->pmd))
32783276
pmde = pmd_wrprotect(pmd_mkuffd_wp(pmde));
32793277
if (!is_migration_entry_young(entry))
32803278
pmde = pmd_mkold(pmde);
32813279
/* NOTE: this may contain setting soft-dirty on some archs */
32823280
if (PageDirty(new) && is_migration_entry_dirty(entry))
32833281
pmde = pmd_mkdirty(pmde);
3282+
if (is_writable_migration_entry(entry))
3283+
pmde = maybe_pmd_mkwrite(pmde, vma);
3284+
else
3285+
pmde = pmd_wrprotect(pmde);
32843286

32853287
if (PageAnon(new)) {
32863288
rmap_t rmap_flags = RMAP_COMPOUND;

mm/khugepaged.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2611,6 +2611,7 @@ static int madvise_collapse_errno(enum scan_result r)
26112611
case SCAN_CGROUP_CHARGE_FAIL:
26122612
return -EBUSY;
26132613
/* Resource temporary unavailable - trying again might succeed */
2614+
case SCAN_PAGE_COUNT:
26142615
case SCAN_PAGE_LOCK:
26152616
case SCAN_PAGE_LRU:
26162617
case SCAN_DEL_PAGE_LRU:

mm/migrate.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,8 @@ static bool remove_migration_pte(struct folio *folio,
224224
pte = maybe_mkwrite(pte, vma);
225225
else if (pte_swp_uffd_wp(*pvmw.pte))
226226
pte = pte_mkuffd_wp(pte);
227+
else
228+
pte = pte_wrprotect(pte);
227229

228230
if (folio_test_anon(folio) && !is_readable_migration_entry(entry))
229231
rmap_flags |= RMAP_EXCLUSIVE;

0 commit comments

Comments
 (0)