Skip to content

Commit 3911535

Browse files
plbossartbroonie
authored andcommitted
ASoC: SOF: Intel: disable IMR boot when resuming from ACPI S4 and S5 states
The IMR was assumed to be preserved when suspending to S4 and S5 states, but community reports invalidate that assumption, the hardware seems to be powered off and the IMR memory content cleared. Make sure regular boot with firmware download is used for S4 and S5. BugLink: thesofproject/sof#5892 Fixes: 5fb5f51 ("ASoC: SOF: Intel: hda-loader: add IMR restore support") Signed-off-by: Pierre-Louis Bossart <[email protected]> Reviewed-by: Ranjani Sridharan <[email protected]> Reviewed-by: Péter Ujfalusi <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 9d2d462 commit 3911535

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

sound/soc/sof/intel/hda-loader.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,8 @@ int hda_dsp_cl_boot_firmware(struct snd_sof_dev *sdev)
389389
struct snd_dma_buffer dmab;
390390
int ret, ret1, i;
391391

392-
if (hda->imrboot_supported && !sdev->first_boot) {
392+
if (sdev->system_suspend_target < SOF_SUSPEND_S4 &&
393+
hda->imrboot_supported && !sdev->first_boot) {
393394
dev_dbg(sdev->dev, "IMR restore supported, booting from IMR directly\n");
394395
hda->boot_iteration = 0;
395396
ret = hda_dsp_boot_imr(sdev);

0 commit comments

Comments
 (0)