Skip to content

Commit 3920068

Browse files
Ewan D. Milnemartinkpetersen
authored andcommitted
scsi: qla2xxx: Fix mailbox direction flags in qla2xxx_get_adapter_id()
The SCM changes set the flags in mcp->out_mb instead of mcp->in_mb so the data was not actually being read into the mcp->mb[] array from the adapter. Link: https://lore.kernel.org/r/[email protected] Fixes: 9f2475f ("scsi: qla2xxx: SAN congestion management implementation") Cc: [email protected] Reviewed-by: Himanshu Madhani <[email protected]> Reviewed-by: Arun Easi <[email protected]> Signed-off-by: Ewan D. Milne <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 5cb37a2 commit 3920068

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/scsi/qla2xxx/qla_mbx.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1695,10 +1695,8 @@ qla2x00_get_adapter_id(scsi_qla_host_t *vha, uint16_t *id, uint8_t *al_pa,
16951695
mcp->in_mb |= MBX_13|MBX_12|MBX_11|MBX_10;
16961696
if (IS_FWI2_CAPABLE(vha->hw))
16971697
mcp->in_mb |= MBX_19|MBX_18|MBX_17|MBX_16;
1698-
if (IS_QLA27XX(vha->hw) || IS_QLA28XX(vha->hw)) {
1699-
mcp->in_mb |= MBX_15;
1700-
mcp->out_mb |= MBX_7|MBX_21|MBX_22|MBX_23;
1701-
}
1698+
if (IS_QLA27XX(vha->hw) || IS_QLA28XX(vha->hw))
1699+
mcp->in_mb |= MBX_15|MBX_21|MBX_22|MBX_23;
17021700

17031701
mcp->tov = MBX_TOV_SECONDS;
17041702
mcp->flags = 0;

0 commit comments

Comments
 (0)