Skip to content

Commit 397b51e

Browse files
committed
drm/i915/psr: 128b/132b Panel Replay is not supported on eDP
Take into account that 128b/132b Panel Replay is not supported on eDP. Bspec: 68920 v2: - make crtc_state as const - add debug message to print out why Panel Replay is not possible Signed-off-by: Jouni Högander <[email protected]> Reviewed-by: Animesh Manna <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 5d9993f commit 397b51e

File tree

1 file changed

+19
-2
lines changed

1 file changed

+19
-2
lines changed

drivers/gpu/drm/i915/display/intel_psr.c

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1517,7 +1517,10 @@ static bool _psr_compute_config(struct intel_dp *intel_dp,
15171517
return true;
15181518
}
15191519

1520-
static bool _panel_replay_compute_config(struct intel_dp *intel_dp)
1520+
static bool
1521+
_panel_replay_compute_config(struct intel_dp *intel_dp,
1522+
const struct intel_crtc_state *crtc_state,
1523+
const struct drm_connector_state *conn_state)
15211524
{
15221525
struct drm_i915_private *i915 = dp_to_i915(intel_dp);
15231526

@@ -1529,6 +1532,18 @@ static bool _panel_replay_compute_config(struct intel_dp *intel_dp)
15291532
return false;
15301533
}
15311534

1535+
if (!intel_dp_is_edp(intel_dp))
1536+
return true;
1537+
1538+
/* Remaining checks are for eDP only */
1539+
1540+
/* 128b/132b Panel Replay is not supported on eDP */
1541+
if (intel_dp_is_uhbr(crtc_state)) {
1542+
drm_dbg_kms(&i915->drm,
1543+
"Panel Replay is not supported with 128b/132b\n");
1544+
return false;
1545+
}
1546+
15321547
return true;
15331548
}
15341549

@@ -1567,7 +1582,9 @@ void intel_psr_compute_config(struct intel_dp *intel_dp,
15671582
return;
15681583
}
15691584

1570-
crtc_state->has_panel_replay = _panel_replay_compute_config(intel_dp);
1585+
crtc_state->has_panel_replay = _panel_replay_compute_config(intel_dp,
1586+
crtc_state,
1587+
conn_state);
15711588

15721589
crtc_state->has_psr = crtc_state->has_panel_replay ? true :
15731590
_psr_compute_config(intel_dp, crtc_state);

0 commit comments

Comments
 (0)