Skip to content

Commit 397d1d8

Browse files
committed
Merge tag 'selinux-pr-20241217' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux
Pull selinux fix from Paul Moore: "One small SELinux patch to get rid improve our handling of unknown extended permissions by safely ignoring them. Not only does this make it easier to support newer SELinux policy on older kernels in the future, it removes to BUG() calls from the SELinux code." * tag 'selinux-pr-20241217' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux: selinux: ignore unknown extended permissions
2 parents c061cf4 + 900f83c commit 397d1d8

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

security/selinux/ss/services.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -979,7 +979,10 @@ void services_compute_xperms_decision(struct extended_perms_decision *xpermd,
979979
return;
980980
break;
981981
default:
982-
BUG();
982+
pr_warn_once(
983+
"SELinux: unknown extended permission (%u) will be ignored\n",
984+
node->datum.u.xperms->specified);
985+
return;
983986
}
984987

985988
if (node->key.specified == AVTAB_XPERMS_ALLOWED) {
@@ -998,7 +1001,8 @@ void services_compute_xperms_decision(struct extended_perms_decision *xpermd,
9981001
&node->datum.u.xperms->perms,
9991002
xpermd->dontaudit);
10001003
} else {
1001-
BUG();
1004+
pr_warn_once("SELinux: unknown specified key (%u)\n",
1005+
node->key.specified);
10021006
}
10031007
}
10041008

0 commit comments

Comments
 (0)