Skip to content

Commit 3993a79

Browse files
lukasfink1alexdeucher
authored andcommitted
drm/amdgpu: Fix rejecting Tahiti GPUs
eb4fd29 ("drm/amdgpu: bind to any 0x1002 PCI diplay class device") added generic bindings to amdgpu so that that it binds to all display class devices with VID 0x1002 and then rejects those in amdgpu_pci_probe. Unfortunately it reuses a driver_data value of 0 to detect those new bindings, which is already used to denote CHIP_TAHITI ASICs. The driver_data value given to those new bindings was changed in dd0761fd24ea1 ("drm/amdgpu: set CHIP_IP_DISCOVERY as the asic type by default") to CHIP_IP_DISCOVERY (=36), but it seems that the check in amdgpu_pci_probe was forgotten to be changed. Therefore, it still rejects Tahiti GPUs. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1860 Fixes: eb4fd29 ("drm/amdgpu: bind to any 0x1002 PCI diplay class device") Cc: [email protected] Signed-off-by: Lukas Fink <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent e8309d5 commit 3993a79

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1907,7 +1907,7 @@ static int amdgpu_pci_probe(struct pci_dev *pdev,
19071907
return -ENODEV;
19081908
}
19091909

1910-
if (flags == 0) {
1910+
if (flags == CHIP_IP_DISCOVERY) {
19111911
DRM_INFO("Unsupported asic. Remove me when IP discovery init is in place.\n");
19121912
return -ENODEV;
19131913
}

0 commit comments

Comments
 (0)