Skip to content

Commit 3998260

Browse files
author
Chun-Kuang Hu
committed
drm/mediatek: Use cmdq_pkt_eoc() instead of cmdq_pkt_finalize()
For some client driver, it want to reduce latency between excuting previous packet command and next packet command, so append jump command to the end of previous packet and the jump destination address is the start address of next packet command buffer. Before next packet exist, the previous packet has no information of where to jump to, so append nop command first. When next packet exist, change nop command to jump command. For mediatek drm driver, it never has next packet, so appending nop command is redundant. Because cmdq_pkt_finalize() would append nop command, so change calling cmdq_pkt_finalize() to cmdq_pkt_eoc() to prevent append redundant nop command. Signed-off-by: Chun-Kuang Hu <[email protected]> Link: https://patchwork.kernel.org/project/dri-devel/patch/[email protected]/
1 parent 4225d5d commit 3998260

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/mediatek/mtk_crtc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -607,7 +607,7 @@ static void mtk_crtc_update_config(struct mtk_crtc *mtk_crtc, bool needs_vblank)
607607
cmdq_pkt_clear_event(cmdq_handle, mtk_crtc->cmdq_event);
608608
cmdq_pkt_wfe(cmdq_handle, mtk_crtc->cmdq_event, false);
609609
mtk_crtc_ddp_config(crtc, cmdq_handle);
610-
cmdq_pkt_finalize(cmdq_handle);
610+
cmdq_pkt_eoc(cmdq_handle);
611611
dma_sync_single_for_device(mtk_crtc->cmdq_client.chan->mbox->dev,
612612
cmdq_handle->pa_base,
613613
cmdq_handle->cmd_buf_size,

0 commit comments

Comments
 (0)