Skip to content

Commit 39e1655

Browse files
vlubartgregkh
authored andcommitted
mei: lower the log level for non-fatal failed messages
Some non-fatal log messages should be logged at INFO log level because failure to send/receive them is not breaking mei functionality and may happen during legal firmware resets Signed-off-by: Vitaly Lubart <[email protected]> Signed-off-by: Tomas Winkler <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 784304a commit 39e1655

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

drivers/misc/mei/bus-fixup.c

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// SPDX-License-Identifier: GPL-2.0
22
/*
3-
* Copyright (c) 2013-2022, Intel Corporation. All rights reserved.
3+
* Copyright (c) 2013-2023, Intel Corporation. All rights reserved.
44
* Intel Management Engine Interface (Intel MEI) Linux driver
55
*/
66

@@ -151,7 +151,7 @@ static int mei_fwver(struct mei_cl_device *cldev)
151151
ret = __mei_cl_send(cldev->cl, (u8 *)&req, sizeof(req), 0,
152152
MEI_CL_IO_TX_BLOCKING);
153153
if (ret < 0) {
154-
dev_err(&cldev->dev, "Could not send ReqFWVersion cmd ret = %d\n", ret);
154+
dev_info(&cldev->dev, "Could not send ReqFWVersion cmd ret = %d\n", ret);
155155
return ret;
156156
}
157157

@@ -163,7 +163,7 @@ static int mei_fwver(struct mei_cl_device *cldev)
163163
* Should be at least one version block,
164164
* error out if nothing found
165165
*/
166-
dev_err(&cldev->dev, "Could not read FW version ret = %d\n", bytes_recv);
166+
dev_info(&cldev->dev, "Could not read FW version ret = %d\n", bytes_recv);
167167
return -EIO;
168168
}
169169

@@ -220,15 +220,15 @@ static void mei_mkhi_fix(struct mei_cl_device *cldev)
220220
if (cldev->bus->fw_f_fw_ver_supported) {
221221
ret = mei_fwver(cldev);
222222
if (ret < 0)
223-
dev_err(&cldev->dev, "FW version command failed %d\n",
224-
ret);
223+
dev_info(&cldev->dev, "FW version command failed %d\n",
224+
ret);
225225
}
226226

227227
if (cldev->bus->hbm_f_os_supported) {
228228
ret = mei_osver(cldev);
229229
if (ret < 0)
230-
dev_err(&cldev->dev, "OS version command failed %d\n",
231-
ret);
230+
dev_info(&cldev->dev, "OS version command failed %d\n",
231+
ret);
232232
}
233233
mei_cldev_disable(cldev);
234234
}
@@ -247,7 +247,7 @@ static void mei_gsc_mkhi_ver(struct mei_cl_device *cldev)
247247

248248
ret = mei_fwver(cldev);
249249
if (ret < 0)
250-
dev_err(&cldev->dev, "FW version command failed %d\n", ret);
250+
dev_info(&cldev->dev, "FW version command failed %d\n", ret);
251251
mei_cldev_disable(cldev);
252252
}
253253

@@ -278,8 +278,8 @@ static void mei_gsc_mkhi_fix_ver(struct mei_cl_device *cldev)
278278

279279
ret = mei_fwver(cldev);
280280
if (ret < 0)
281-
dev_err(&cldev->dev, "FW version command failed %d\n",
282-
ret);
281+
dev_info(&cldev->dev, "FW version command failed %d\n",
282+
ret);
283283
out:
284284
mei_cldev_disable(cldev);
285285
}
@@ -403,7 +403,7 @@ static int mei_nfc_if_version(struct mei_cl *cl,
403403
memcpy(ver, reply->data, sizeof(*ver));
404404

405405
dev_info(bus->dev, "NFC MEI VERSION: IVN 0x%x Vendor ID 0x%x Type 0x%x\n",
406-
ver->fw_ivn, ver->vendor_id, ver->radio_type);
406+
ver->fw_ivn, ver->vendor_id, ver->radio_type);
407407

408408
err:
409409
kfree(reply);

0 commit comments

Comments
 (0)