Skip to content

Commit 3a16101

Browse files
ziswilervinodkoul
authored andcommitted
phy: freescale: imx8m-pcie: fix pcie link-up instability
Leaving AUX_PLL_REFCLK_SEL at its reset default of AUX_IN (PLL clock) proves to be more stable on the i.MX 8M Mini. Fixes: 1aa97b0 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver") Signed-off-by: Marcel Ziswiler <[email protected]> Reviewed-by: Richard Zhu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 6272077 commit 3a16101

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/phy/freescale/phy-fsl-imx8m-pcie.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,10 @@ static int imx8_pcie_phy_power_on(struct phy *phy)
110110
/* Source clock from SoC internal PLL */
111111
writel(ANA_PLL_CLK_OUT_TO_EXT_IO_SEL,
112112
imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG062);
113-
writel(AUX_PLL_REFCLK_SEL_SYS_PLL,
114-
imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG063);
113+
if (imx8_phy->drvdata->variant != IMX8MM) {
114+
writel(AUX_PLL_REFCLK_SEL_SYS_PLL,
115+
imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG063);
116+
}
115117
val = ANA_AUX_RX_TX_SEL_TX | ANA_AUX_TX_TERM;
116118
writel(val | ANA_AUX_RX_TERM_GND_EN,
117119
imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG064);

0 commit comments

Comments
 (0)