Skip to content

Commit 3a3a100

Browse files
anderssonlinusw
authored andcommitted
pinctrl: qcom: sdm845: Enable dual edge errata
It has been observed that dual edge triggered wakeirq GPIOs on SDM845 doesn't trigger interrupts on the falling edge. Enabling wakeirq_dual_edge_errata for SDM845 indicates that the PDC in SDM845 suffers from the same problem described, and worked around, by Doug in 'c3c0c2e18d94 ("pinctrl: qcom: Handle broken/missing PDC dual edge IRQs on sc7180")', so enable the workaround for SDM845 as well. The specific problem seen without this is that gpio-keys does not detect the falling edge of the LID gpio on the Lenovo Yoga C630 and as such consistently reports the LID as closed. Fixes: e35a6ae ("pinctrl/msm: Setup GPIO chip in hierarchy") Signed-off-by: Bjorn Andersson <[email protected]> Tested-By: Steev Klimaszewski <[email protected]> Reviewed-by: Douglas Anderson <[email protected]> Reviewed-by: Stephen Boyd <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Linus Walleij <[email protected]>
1 parent 9b3b94e commit 3a3a100

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/pinctrl/qcom/pinctrl-sdm845.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1310,6 +1310,7 @@ static const struct msm_pinctrl_soc_data sdm845_pinctrl = {
13101310
.ngpios = 151,
13111311
.wakeirq_map = sdm845_pdc_map,
13121312
.nwakeirq_map = ARRAY_SIZE(sdm845_pdc_map),
1313+
.wakeirq_dual_edge_errata = true,
13131314
};
13141315

13151316
static const struct msm_pinctrl_soc_data sdm845_acpi_pinctrl = {

0 commit comments

Comments
 (0)