Skip to content

Commit 3a5fd0d

Browse files
tititiou36vinodkoul
authored andcommitted
dmaengine: tegra210-adma: Fix an error handling path in 'tegra_adma_probe()'
Commit b53611f ("dmaengine: tegra210-adma: Fix crash during probe") has moved some code in the probe function and reordered the error handling path accordingly. However, a goto has been missed. Fix it and goto the right label if 'dma_async_device_register()' fails, so that all resources are released. Fixes: b53611f ("dmaengine: tegra210-adma: Fix crash during probe") Signed-off-by: Christophe JAILLET <[email protected]> Reviewed-by: Jon Hunter <[email protected]> Acked-by: Thierry Reding <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent be4054b commit 3a5fd0d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/dma/tegra210-adma.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -900,7 +900,7 @@ static int tegra_adma_probe(struct platform_device *pdev)
900900
ret = dma_async_device_register(&tdma->dma_dev);
901901
if (ret < 0) {
902902
dev_err(&pdev->dev, "ADMA registration failed: %d\n", ret);
903-
goto irq_dispose;
903+
goto rpm_put;
904904
}
905905

906906
ret = of_dma_controller_register(pdev->dev.of_node,

0 commit comments

Comments
 (0)