Skip to content

Commit 3a6a399

Browse files
jdelvareWim Van Sebroeck
authored andcommitted
watchdog: Delete the cpu5wdt driver
This driver has a number of issues (accesses arbitrary I/O ports without identifying the hardware, doesn't document what hardware it supports, suspiciously inconsistent locking model, doesn't implement WDIOC_SETTIMEOUT, potential integer overflow...) The driver was added in 2003 and there's no evidence that it has any recent user, all changes seem to be tree-wide, subsystem-wide, or the result of static code analysis. So I believe we should simply drop this legacy piece of code. Signed-off-by: Jean Delvare <[email protected]> Message-ID: <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Guenter Roeck <[email protected]> Signed-off-by: Wim Van Sebroeck <[email protected]>
1 parent 3cf67f3 commit 3a6a399

File tree

4 files changed

+0
-303
lines changed

4 files changed

+0
-303
lines changed

Documentation/watchdog/watchdog-parameters.rst

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -120,16 +120,6 @@ coh901327_wdt:
120120

121121
-------------------------------------------------
122122

123-
cpu5wdt:
124-
port:
125-
base address of watchdog card, default is 0x91
126-
verbose:
127-
be verbose, default is 0 (no)
128-
ticks:
129-
count down ticks, default is 10000
130-
131-
-------------------------------------------------
132-
133123
cpwd:
134124
wd0_timeout:
135125
Default watchdog0 timeout in 1/10secs

drivers/watchdog/Kconfig

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1541,14 +1541,6 @@ config SBC7240_WDT
15411541
To compile this driver as a module, choose M here: the
15421542
module will be called sbc7240_wdt.
15431543

1544-
config CPU5_WDT
1545-
tristate "SMA CPU5 Watchdog"
1546-
depends on (X86 || COMPILE_TEST) && HAS_IOPORT
1547-
help
1548-
TBD.
1549-
To compile this driver as a module, choose M here: the
1550-
module will be called cpu5wdt.
1551-
15521544
config SMSC_SCH311X_WDT
15531545
tristate "SMSC SCH311X Watchdog Timer"
15541546
depends on (X86 || COMPILE_TEST) && HAS_IOPORT

drivers/watchdog/Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ obj-$(CONFIG_RDC321X_WDT) += rdc321x_wdt.o
138138
obj-$(CONFIG_60XX_WDT) += sbc60xxwdt.o
139139
obj-$(CONFIG_SBC8360_WDT) += sbc8360.o
140140
obj-$(CONFIG_SBC7240_WDT) += sbc7240_wdt.o
141-
obj-$(CONFIG_CPU5_WDT) += cpu5wdt.o
142141
obj-$(CONFIG_SMSC_SCH311X_WDT) += sch311x_wdt.o
143142
obj-$(CONFIG_SMSC37B787_WDT) += smsc37b787_wdt.o
144143
obj-$(CONFIG_TQMX86_WDT) += tqmx86_wdt.o

drivers/watchdog/cpu5wdt.c

Lines changed: 0 additions & 284 deletions
This file was deleted.

0 commit comments

Comments
 (0)