Skip to content

Commit 3a9a2c8

Browse files
jwrdegoedeJiri Kosina
authored andcommitted
HID: logitech-dj: Fix forwarding of very long HID++ reports
The HID++ spec also defines very long HID++ reports, with a reportid of 0x12. The MX5000 and MX5500 keyboards use 0x12 output reports for sending messages to display on their buildin LCD. Userspace (libmx5000) supports this, in order for this to work when talking to the HID devices instantiated for the keyboard by hid-logitech-dj, we need to properly forward these reports to the device. This commit fixes logi_dj_ll_raw_request not forwarding these reports. Fixes: f2113c3 ("HID: logitech-dj: add support for Logitech Bluetooth Mini-Receiver") Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent 315ffcc commit 3a9a2c8

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/hid/hid-logitech-dj.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545

4646
#define REPORT_ID_HIDPP_SHORT 0x10
4747
#define REPORT_ID_HIDPP_LONG 0x11
48+
#define REPORT_ID_HIDPP_VERY_LONG 0x12
4849

4950
#define HIDPP_REPORT_SHORT_LENGTH 7
5051
#define HIDPP_REPORT_LONG_LENGTH 20
@@ -1257,7 +1258,8 @@ static int logi_dj_ll_raw_request(struct hid_device *hid,
12571258
int ret;
12581259

12591260
if ((buf[0] == REPORT_ID_HIDPP_SHORT) ||
1260-
(buf[0] == REPORT_ID_HIDPP_LONG)) {
1261+
(buf[0] == REPORT_ID_HIDPP_LONG) ||
1262+
(buf[0] == REPORT_ID_HIDPP_VERY_LONG)) {
12611263
if (count < 2)
12621264
return -EINVAL;
12631265

0 commit comments

Comments
 (0)