Skip to content

Commit 3b35e7e

Browse files
rddunlapKAGA-KOKO
authored andcommitted
genirq: Fix kernel-doc warnings in pm.c, msi.c and ipi.c
Fix all kernel-doc warnings in these 3 files and do some simple editing (capitalize acronyms, capitalize Linux). kernel/irq/pm.c:235: warning: expecting prototype for irq_pm_syscore_ops(). Prototype was for irq_pm_syscore_resume() instead kernel/irq/msi.c:530: warning: expecting prototype for __msi_domain_free_irqs(). Prototype was for msi_domain_free_irqs() instead kernel/irq/msi.c:31: warning: No description found for return value of 'alloc_msi_entry' kernel/irq/msi.c:103: warning: No description found for return value of 'msi_domain_set_affinity' kernel/irq/msi.c:288: warning: No description found for return value of 'msi_create_irq_domain' kernel/irq/msi.c:499: warning: No description found for return value of 'msi_domain_alloc_irqs' kernel/irq/msi.c:545: warning: No description found for return value of 'msi_get_domain_info' kernel/irq/ipi.c:264: warning: expecting prototype for ipi_send_mask(). Prototype was for __ipi_send_mask() instead kernel/irq/ipi.c:25: warning: No description found for return value of 'irq_reserve_ipi' kernel/irq/ipi.c:116: warning: No description found for return value of 'irq_destroy_ipi' kernel/irq/ipi.c:163: warning: No description found for return value of 'ipi_get_hwirq' kernel/irq/ipi.c:222: warning: No description found for return value of '__ipi_send_single' kernel/irq/ipi.c:308: warning: No description found for return value of 'ipi_send_single' kernel/irq/ipi.c:329: warning: No description found for return value of 'ipi_send_mask' Signed-off-by: Randy Dunlap <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 290fdc4 commit 3b35e7e

File tree

3 files changed

+29
-24
lines changed

3 files changed

+29
-24
lines changed

kernel/irq/ipi.c

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@
1414
/**
1515
* irq_reserve_ipi() - Setup an IPI to destination cpumask
1616
* @domain: IPI domain
17-
* @dest: cpumask of cpus which can receive the IPI
17+
* @dest: cpumask of CPUs which can receive the IPI
1818
*
1919
* Allocate a virq that can be used to send IPI to any CPU in dest mask.
2020
*
21-
* On success it'll return linux irq number and error code on failure
21+
* Return: Linux IRQ number on success or error code on failure
2222
*/
2323
int irq_reserve_ipi(struct irq_domain *domain,
2424
const struct cpumask *dest)
@@ -104,13 +104,13 @@ int irq_reserve_ipi(struct irq_domain *domain,
104104

105105
/**
106106
* irq_destroy_ipi() - unreserve an IPI that was previously allocated
107-
* @irq: linux irq number to be destroyed
108-
* @dest: cpumask of cpus which should have the IPI removed
107+
* @irq: Linux IRQ number to be destroyed
108+
* @dest: cpumask of CPUs which should have the IPI removed
109109
*
110110
* The IPIs allocated with irq_reserve_ipi() are returned to the system
111111
* destroying all virqs associated with them.
112112
*
113-
* Return 0 on success or error code on failure.
113+
* Return: %0 on success or error code on failure.
114114
*/
115115
int irq_destroy_ipi(unsigned int irq, const struct cpumask *dest)
116116
{
@@ -150,14 +150,14 @@ int irq_destroy_ipi(unsigned int irq, const struct cpumask *dest)
150150
}
151151

152152
/**
153-
* ipi_get_hwirq - Get the hwirq associated with an IPI to a cpu
154-
* @irq: linux irq number
155-
* @cpu: the target cpu
153+
* ipi_get_hwirq - Get the hwirq associated with an IPI to a CPU
154+
* @irq: Linux IRQ number
155+
* @cpu: the target CPU
156156
*
157157
* When dealing with coprocessors IPI, we need to inform the coprocessor of
158158
* the hwirq it needs to use to receive and send IPIs.
159159
*
160-
* Returns hwirq value on success and INVALID_HWIRQ on failure.
160+
* Return: hwirq value on success or INVALID_HWIRQ on failure.
161161
*/
162162
irq_hw_number_t ipi_get_hwirq(unsigned int irq, unsigned int cpu)
163163
{
@@ -216,7 +216,7 @@ static int ipi_send_verify(struct irq_chip *chip, struct irq_data *data,
216216
* This function is for architecture or core code to speed up IPI sending. Not
217217
* usable from driver code.
218218
*
219-
* Returns zero on success and negative error number on failure.
219+
* Return: %0 on success or negative error number on failure.
220220
*/
221221
int __ipi_send_single(struct irq_desc *desc, unsigned int cpu)
222222
{
@@ -250,15 +250,15 @@ int __ipi_send_single(struct irq_desc *desc, unsigned int cpu)
250250
}
251251

252252
/**
253-
* ipi_send_mask - send an IPI to target Linux SMP CPU(s)
253+
* __ipi_send_mask - send an IPI to target Linux SMP CPU(s)
254254
* @desc: pointer to irq_desc of the IRQ
255255
* @dest: dest CPU(s), must be a subset of the mask passed to
256256
* irq_reserve_ipi()
257257
*
258258
* This function is for architecture or core code to speed up IPI sending. Not
259259
* usable from driver code.
260260
*
261-
* Returns zero on success and negative error number on failure.
261+
* Return: %0 on success or negative error number on failure.
262262
*/
263263
int __ipi_send_mask(struct irq_desc *desc, const struct cpumask *dest)
264264
{
@@ -298,11 +298,11 @@ int __ipi_send_mask(struct irq_desc *desc, const struct cpumask *dest)
298298

299299
/**
300300
* ipi_send_single - Send an IPI to a single CPU
301-
* @virq: linux irq number from irq_reserve_ipi()
301+
* @virq: Linux IRQ number from irq_reserve_ipi()
302302
* @cpu: destination CPU, must in the destination mask passed to
303303
* irq_reserve_ipi()
304304
*
305-
* Returns zero on success and negative error number on failure.
305+
* Return: %0 on success or negative error number on failure.
306306
*/
307307
int ipi_send_single(unsigned int virq, unsigned int cpu)
308308
{
@@ -319,11 +319,11 @@ EXPORT_SYMBOL_GPL(ipi_send_single);
319319

320320
/**
321321
* ipi_send_mask - Send an IPI to target CPU(s)
322-
* @virq: linux irq number from irq_reserve_ipi()
322+
* @virq: Linux IRQ number from irq_reserve_ipi()
323323
* @dest: dest CPU(s), must be a subset of the mask passed to
324324
* irq_reserve_ipi()
325325
*
326-
* Returns zero on success and negative error number on failure.
326+
* Return: %0 on success or negative error number on failure.
327327
*/
328328
int ipi_send_mask(unsigned int virq, const struct cpumask *dest)
329329
{

kernel/irq/msi.c

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,15 @@
1818
#include "internals.h"
1919

2020
/**
21-
* alloc_msi_entry - Allocate an initialize msi_entry
21+
* alloc_msi_entry - Allocate an initialized msi_desc
2222
* @dev: Pointer to the device for which this is allocated
2323
* @nvec: The number of vectors used in this entry
2424
* @affinity: Optional pointer to an affinity mask array size of @nvec
2525
*
26-
* If @affinity is not NULL then an affinity array[@nvec] is allocated
26+
* If @affinity is not %NULL then an affinity array[@nvec] is allocated
2727
* and the affinity masks and flags from @affinity are copied.
28+
*
29+
* Return: pointer to allocated &msi_desc on success or %NULL on failure
2830
*/
2931
struct msi_desc *alloc_msi_entry(struct device *dev, int nvec,
3032
const struct irq_affinity_desc *affinity)
@@ -97,6 +99,8 @@ static void msi_check_level(struct irq_domain *domain, struct msi_msg *msg)
9799
*
98100
* Intended to be used by MSI interrupt controllers which are
99101
* implemented with hierarchical domains.
102+
*
103+
* Return: IRQ_SET_MASK_* result code
100104
*/
101105
int msi_domain_set_affinity(struct irq_data *irq_data,
102106
const struct cpumask *mask, bool force)
@@ -277,10 +281,12 @@ static void msi_domain_update_chip_ops(struct msi_domain_info *info)
277281
}
278282

279283
/**
280-
* msi_create_irq_domain - Create a MSI interrupt domain
284+
* msi_create_irq_domain - Create an MSI interrupt domain
281285
* @fwnode: Optional fwnode of the interrupt controller
282286
* @info: MSI domain info
283287
* @parent: Parent irq domain
288+
*
289+
* Return: pointer to the created &struct irq_domain or %NULL on failure
284290
*/
285291
struct irq_domain *msi_create_irq_domain(struct fwnode_handle *fwnode,
286292
struct msi_domain_info *info,
@@ -492,7 +498,7 @@ int __msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
492498
* are allocated
493499
* @nvec: The number of interrupts to allocate
494500
*
495-
* Returns 0 on success or an error code.
501+
* Return: %0 on success or an error code.
496502
*/
497503
int msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
498504
int nvec)
@@ -521,7 +527,7 @@ void __msi_domain_free_irqs(struct irq_domain *domain, struct device *dev)
521527
}
522528

523529
/**
524-
* __msi_domain_free_irqs - Free interrupts from a MSI interrupt @domain associated tp @dev
530+
* msi_domain_free_irqs - Free interrupts from a MSI interrupt @domain associated to @dev
525531
* @domain: The domain to managing the interrupts
526532
* @dev: Pointer to device struct of the device for which the interrupts
527533
* are free
@@ -538,8 +544,7 @@ void msi_domain_free_irqs(struct irq_domain *domain, struct device *dev)
538544
* msi_get_domain_info - Get the MSI interrupt domain info for @domain
539545
* @domain: The interrupt domain to retrieve data from
540546
*
541-
* Returns the pointer to the msi_domain_info stored in
542-
* @domain->host_data.
547+
* Return: the pointer to the msi_domain_info stored in @domain->host_data.
543548
*/
544549
struct msi_domain_info *msi_get_domain_info(struct irq_domain *domain)
545550
{

kernel/irq/pm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ void rearm_wake_irq(unsigned int irq)
227227
}
228228

229229
/**
230-
* irq_pm_syscore_ops - enable interrupt lines early
230+
* irq_pm_syscore_resume - enable interrupt lines early
231231
*
232232
* Enable all interrupt lines with %IRQF_EARLY_RESUME set.
233233
*/

0 commit comments

Comments
 (0)