Skip to content

Commit 3b41b61

Browse files
jhovoldvinodkoul
authored andcommitted
phy: qcom-qmp-usb: drop sc8280xp reference-clock source
The source clock for the reference clock is not used by the PHY directly and should not be described by the devicetree (instead this relationship should be modelled in the clock driver). Drop the driver management of the reference-clock source for SC8280XP. Once the other clock drivers have been updated, the corresponding change can be done also for the other QMP v4 platforms. Signed-off-by: Johan Hovold <[email protected]> Reviewed-by: Dmitry Baryshkov <[email protected]> Reviewed-by: Bjorn Andersson <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 1446d03 commit 3b41b61

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

drivers/phy/qualcomm/phy-qcom-qmp-usb.c

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1523,6 +1523,10 @@ static const char * const qmp_v3_phy_clk_l[] = {
15231523
};
15241524

15251525
static const char * const qmp_v4_phy_clk_l[] = {
1526+
"aux", "ref", "com_aux",
1527+
};
1528+
1529+
static const char * const qmp_v4_ref_phy_clk_l[] = {
15261530
"aux", "ref_clk_src", "ref", "com_aux",
15271531
};
15281532

@@ -1729,8 +1733,8 @@ static const struct qmp_phy_cfg sm8150_usb3phy_cfg = {
17291733
.pcs_tbl_num = ARRAY_SIZE(sm8150_usb3_pcs_tbl),
17301734
.pcs_usb_tbl = sm8150_usb3_pcs_usb_tbl,
17311735
.pcs_usb_tbl_num = ARRAY_SIZE(sm8150_usb3_pcs_usb_tbl),
1732-
.clk_list = qmp_v4_phy_clk_l,
1733-
.num_clks = ARRAY_SIZE(qmp_v4_phy_clk_l),
1736+
.clk_list = qmp_v4_ref_phy_clk_l,
1737+
.num_clks = ARRAY_SIZE(qmp_v4_ref_phy_clk_l),
17341738
.reset_list = msm8996_usb3phy_reset_l,
17351739
.num_resets = ARRAY_SIZE(msm8996_usb3phy_reset_l),
17361740
.vreg_list = qmp_phy_vreg_l,
@@ -1755,8 +1759,8 @@ static const struct qmp_phy_cfg sm8150_usb3_uniphy_cfg = {
17551759
.pcs_tbl_num = ARRAY_SIZE(sm8150_usb3_uniphy_pcs_tbl),
17561760
.pcs_usb_tbl = sm8150_usb3_uniphy_pcs_usb_tbl,
17571761
.pcs_usb_tbl_num = ARRAY_SIZE(sm8150_usb3_uniphy_pcs_usb_tbl),
1758-
.clk_list = qmp_v4_phy_clk_l,
1759-
.num_clks = ARRAY_SIZE(qmp_v4_phy_clk_l),
1762+
.clk_list = qmp_v4_ref_phy_clk_l,
1763+
.num_clks = ARRAY_SIZE(qmp_v4_ref_phy_clk_l),
17601764
.reset_list = msm8996_usb3phy_reset_l,
17611765
.num_resets = ARRAY_SIZE(msm8996_usb3phy_reset_l),
17621766
.vreg_list = qmp_phy_vreg_l,
@@ -1806,8 +1810,8 @@ static const struct qmp_phy_cfg sm8250_usb3_uniphy_cfg = {
18061810
.pcs_tbl_num = ARRAY_SIZE(sm8250_usb3_uniphy_pcs_tbl),
18071811
.pcs_usb_tbl = sm8250_usb3_uniphy_pcs_usb_tbl,
18081812
.pcs_usb_tbl_num = ARRAY_SIZE(sm8250_usb3_uniphy_pcs_usb_tbl),
1809-
.clk_list = qmp_v4_phy_clk_l,
1810-
.num_clks = ARRAY_SIZE(qmp_v4_phy_clk_l),
1813+
.clk_list = qmp_v4_ref_phy_clk_l,
1814+
.num_clks = ARRAY_SIZE(qmp_v4_ref_phy_clk_l),
18111815
.reset_list = msm8996_usb3phy_reset_l,
18121816
.num_resets = ARRAY_SIZE(msm8996_usb3phy_reset_l),
18131817
.vreg_list = qmp_phy_vreg_l,
@@ -1907,8 +1911,8 @@ static const struct qmp_phy_cfg sm8350_usb3_uniphy_cfg = {
19071911
.pcs_tbl_num = ARRAY_SIZE(sm8350_usb3_uniphy_pcs_tbl),
19081912
.pcs_usb_tbl = sm8350_usb3_uniphy_pcs_usb_tbl,
19091913
.pcs_usb_tbl_num = ARRAY_SIZE(sm8350_usb3_uniphy_pcs_usb_tbl),
1910-
.clk_list = qmp_v4_phy_clk_l,
1911-
.num_clks = ARRAY_SIZE(qmp_v4_phy_clk_l),
1914+
.clk_list = qmp_v4_ref_phy_clk_l,
1915+
.num_clks = ARRAY_SIZE(qmp_v4_ref_phy_clk_l),
19121916
.reset_list = msm8996_usb3phy_reset_l,
19131917
.num_resets = ARRAY_SIZE(msm8996_usb3phy_reset_l),
19141918
.vreg_list = qmp_phy_vreg_l,

0 commit comments

Comments
 (0)