Skip to content

Commit 3b77093

Browse files
Yang YingliangJiri Kosina
authored andcommitted
HID: thrustmaster: Switch to kmemdup() when allocate change_request
Use kmemdup() helper instead of open-coding to simplify the code when allocate change_request. Signed-off-by: Yang Yingliang <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent 424d823 commit 3b77093

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/hid/hid-thrustmaster.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,12 +311,13 @@ static int thrustmaster_probe(struct hid_device *hdev, const struct hid_device_i
311311
goto error4;
312312
}
313313

314-
tm_wheel->change_request = kzalloc(sizeof(struct usb_ctrlrequest), GFP_KERNEL);
314+
tm_wheel->change_request = kmemdup(&change_request,
315+
sizeof(struct usb_ctrlrequest),
316+
GFP_KERNEL);
315317
if (!tm_wheel->change_request) {
316318
ret = -ENOMEM;
317319
goto error5;
318320
}
319-
memcpy(tm_wheel->change_request, &change_request, sizeof(struct usb_ctrlrequest));
320321

321322
tm_wheel->usb_dev = interface_to_usbdev(to_usb_interface(hdev->dev.parent));
322323
hid_set_drvdata(hdev, tm_wheel);

0 commit comments

Comments
 (0)