Skip to content

Commit 3bbb331

Browse files
zhang-ruilenb
authored andcommitted
tools/power/turbostat: Introduce BIC_SAM_mc6/BIC_SAMMHz/BIC_SAMACTMHz
Graphics driver (i915/Xe) on mordern platforms splits GFX and SA Media information via different sysfs knobs. Existing BIC_GFX_rc6/BIC_GFXMHz/BIC_GFXACTMHz columns can be reused for GFX. Introduce BIC_SAM_mc6/BIC_SAMMHz/BIC_SAMACTMHz columns for SA Media. Signed-off-by: Zhang Rui <[email protected]>
1 parent 60add81 commit 3bbb331

File tree

2 files changed

+96
-7
lines changed

2 files changed

+96
-7
lines changed

tools/power/x86/turbostat/turbostat.8

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,17 @@ The system configuration dump (if --quiet is not used) is followed by statistics
129129
.PP
130130
\fBPkgTmp\fP Degrees Celsius reported by the per-package Package Thermal Monitor.
131131
.PP
132-
\fBGFX%rc6\fP The percentage of time the GPU is in the "render C6" state, rc6, during the measurement interval. From /sys/class/drm/card0/power/rc6_residency_ms.
132+
\fBGFX%rc6\fP The percentage of time the GPU is in the "render C6" state, rc6, during the measurement interval. From /sys/class/drm/card0/power/rc6_residency_ms or /sys/class/drm/card0/gt/gt0/rc6_residency_ms or /sys/class/drm/card0/device/tile0/gtN/gtidle/idle_residency_ms depending on the graphics driver being used.
133133
.PP
134-
\fBGFXMHz\fP Instantaneous snapshot of what sysfs presents at the end of the measurement interval. From /sys/class/graphics/fb0/device/drm/card0/gt_cur_freq_mhz.
134+
\fBGFXMHz\fP Instantaneous snapshot of what sysfs presents at the end of the measurement interval. From /sys/class/graphics/fb0/device/drm/card0/gt_cur_freq_mhz or /sys/class/drm/card0/gt_cur_freq_mhz or /sys/class/drm/card0/gt/gt0/rps_cur_freq_mhz or /sys/class/drm/card0/device/tile0/gtN/freq0/cur_freq depending on the graphics driver being used.
135+
.PP
136+
\fBGFXAMHz\fP Instantaneous snapshot of what sysfs presents at the end of the measurement interval. From /sys/class/graphics/fb0/device/drm/card0/gt_act_freq_mhz or /sys/class/drm/card0/gt_act_freq_mhz or /sys/class/drm/card0/gt/gt0/rps_act_freq_mhz or /sys/class/drm/card0/device/tile0/gtN/freq0/act_freq depending on the graphics driver being used.
137+
.PP
138+
\fBSAM%mc6\fP The percentage of time the SA Media is in the "module C6" state, mc6, during the measurement interval. From /sys/class/drm/card0/gt/gt1/rc6_residency_ms or /sys/class/drm/card0/device/tile0/gtN/gtidle/idle_residency_ms depending on the graphics driver being used.
139+
.PP
140+
\fBSAMMHz\fP Instantaneous snapshot of what sysfs presents at the end of the measurement interval. From /sys/class/drm/card0/gt/gt1/rps_cur_freq_mhz or /sys/class/drm/card0/device/tile0/gtN/freq0/cur_freq depending on the graphics driver being used.
141+
.PP
142+
\fBSAMAMHz\fP Instantaneous snapshot of what sysfs presents at the end of the measurement interval. From /sys/class/drm/card0/gt/gt1/rps_act_freq_mhz or /sys/class/drm/card0/device/tile0/gtN/freq0/act_freq depending on the graphics driver being used.
135143
.PP
136144
\fBPkg%pc2, Pkg%pc3, Pkg%pc6, Pkg%pc7\fP percentage residency in hardware package idle states. These numbers are from hardware residency counters.
137145
.PP

tools/power/x86/turbostat/turbostat.c

Lines changed: 86 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,9 @@ struct msr_counter bic[] = {
133133
{ 0x0, "IPC", "", 0, 0, 0, NULL, 0 },
134134
{ 0x0, "CoreThr", "", 0, 0, 0, NULL, 0 },
135135
{ 0x0, "UncMHz", "", 0, 0, 0, NULL, 0 },
136+
{ 0x0, "SAM%mc6", "", 0, 0, 0, NULL, 0 },
137+
{ 0x0, "SAMMHz", "", 0, 0, 0, NULL, 0 },
138+
{ 0x0, "SAMAMHz", "", 0, 0, 0, NULL, 0 },
136139
};
137140

138141
#define MAX_BIC (sizeof(bic) / sizeof(struct msr_counter))
@@ -191,11 +194,14 @@ struct msr_counter bic[] = {
191194
#define BIC_IPC (1ULL << 52)
192195
#define BIC_CORE_THROT_CNT (1ULL << 53)
193196
#define BIC_UNCORE_MHZ (1ULL << 54)
197+
#define BIC_SAM_mc6 (1ULL << 55)
198+
#define BIC_SAMMHz (1ULL << 56)
199+
#define BIC_SAMACTMHz (1ULL << 57)
194200

195201
#define BIC_TOPOLOGY (BIC_Package | BIC_Node | BIC_CoreCnt | BIC_PkgCnt | BIC_Core | BIC_CPU | BIC_Die )
196202
#define BIC_THERMAL_PWR ( BIC_CoreTmp | BIC_PkgTmp | BIC_PkgWatt | BIC_CorWatt | BIC_GFXWatt | BIC_RAMWatt | BIC_PKG__ | BIC_RAM__)
197-
#define BIC_FREQUENCY ( BIC_Avg_MHz | BIC_Busy | BIC_Bzy_MHz | BIC_TSC_MHz | BIC_GFXMHz | BIC_GFXACTMHz | BIC_UNCORE_MHZ)
198-
#define BIC_IDLE ( BIC_sysfs | BIC_CPU_c1 | BIC_CPU_c3 | BIC_CPU_c6 | BIC_CPU_c7 | BIC_GFX_rc6 | BIC_Pkgpc2 | BIC_Pkgpc3 | BIC_Pkgpc6 | BIC_Pkgpc7 | BIC_Pkgpc8 | BIC_Pkgpc9 | BIC_Pkgpc10 | BIC_CPU_LPI | BIC_SYS_LPI | BIC_Mod_c6 | BIC_Totl_c0 | BIC_Any_c0 | BIC_GFX_c0 | BIC_CPUGFX)
203+
#define BIC_FREQUENCY (BIC_Avg_MHz | BIC_Busy | BIC_Bzy_MHz | BIC_TSC_MHz | BIC_GFXMHz | BIC_GFXACTMHz | BIC_SAMMHz | BIC_SAMACTMHz | BIC_UNCORE_MHZ)
204+
#define BIC_IDLE (BIC_sysfs | BIC_CPU_c1 | BIC_CPU_c3 | BIC_CPU_c6 | BIC_CPU_c7 | BIC_GFX_rc6 | BIC_Pkgpc2 | BIC_Pkgpc3 | BIC_Pkgpc6 | BIC_Pkgpc7 | BIC_Pkgpc8 | BIC_Pkgpc9 | BIC_Pkgpc10 | BIC_CPU_LPI | BIC_SYS_LPI | BIC_Mod_c6 | BIC_Totl_c0 | BIC_Any_c0 | BIC_GFX_c0 | BIC_CPUGFX | BIC_SAM_mc6)
199205
#define BIC_OTHER ( BIC_IRQ | BIC_SMI | BIC_ThreadC | BIC_CoreTmp | BIC_IPC)
200206

201207
#define BIC_DISABLED_BY_DEFAULT (BIC_USEC | BIC_TOD | BIC_APIC | BIC_X2APIC)
@@ -277,6 +283,9 @@ enum gfx_sysfs_idx {
277283
GFX_rc6,
278284
GFX_MHz,
279285
GFX_ACTMHz,
286+
SAM_mc6,
287+
SAM_MHz,
288+
SAM_ACTMHz,
280289
GFX_MAX
281290
};
282291

@@ -1193,6 +1202,9 @@ struct pkg_data {
11931202
long long gfx_rc6_ms;
11941203
unsigned int gfx_mhz;
11951204
unsigned int gfx_act_mhz;
1205+
long long sam_mc6_ms;
1206+
unsigned int sam_mhz;
1207+
unsigned int sam_act_mhz;
11961208
unsigned int package_id;
11971209
struct rapl_counter energy_pkg; /* MSR_PKG_ENERGY_STATUS */
11981210
struct rapl_counter energy_dram; /* MSR_DRAM_ENERGY_STATUS */
@@ -1844,6 +1856,15 @@ void print_header(char *delim)
18441856
if (DO_BIC(BIC_GFXACTMHz))
18451857
outp += sprintf(outp, "%sGFXAMHz", (printed++ ? delim : ""));
18461858

1859+
if (DO_BIC(BIC_SAM_mc6))
1860+
outp += sprintf(outp, "%sSAM%%mc6", (printed++ ? delim : ""));
1861+
1862+
if (DO_BIC(BIC_SAMMHz))
1863+
outp += sprintf(outp, "%sSAMMHz", (printed++ ? delim : ""));
1864+
1865+
if (DO_BIC(BIC_SAMACTMHz))
1866+
outp += sprintf(outp, "%sSAMAMHz", (printed++ ? delim : ""));
1867+
18471868
if (DO_BIC(BIC_Totl_c0))
18481869
outp += sprintf(outp, "%sTotl%%C0", (printed++ ? delim : ""));
18491870
if (DO_BIC(BIC_Any_c0))
@@ -2251,6 +2272,24 @@ int format_counters(struct thread_data *t, struct core_data *c, struct pkg_data
22512272
if (DO_BIC(BIC_GFXACTMHz))
22522273
outp += sprintf(outp, "%s%d", (printed++ ? delim : ""), p->gfx_act_mhz);
22532274

2275+
/* SAMmc6 */
2276+
if (DO_BIC(BIC_SAM_mc6)) {
2277+
if (p->sam_mc6_ms == -1) { /* detect GFX counter reset */
2278+
outp += sprintf(outp, "%s**.**", (printed++ ? delim : ""));
2279+
} else {
2280+
outp += sprintf(outp, "%s%.2f", (printed++ ? delim : ""),
2281+
p->sam_mc6_ms / 10.0 / interval_float);
2282+
}
2283+
}
2284+
2285+
/* SAMMHz */
2286+
if (DO_BIC(BIC_SAMMHz))
2287+
outp += sprintf(outp, "%s%d", (printed++ ? delim : ""), p->sam_mhz);
2288+
2289+
/* SAMACTMHz */
2290+
if (DO_BIC(BIC_SAMACTMHz))
2291+
outp += sprintf(outp, "%s%d", (printed++ ? delim : ""), p->sam_act_mhz);
2292+
22542293
/* Totl%C0, Any%C0 GFX%C0 CPUGFX% */
22552294
if (DO_BIC(BIC_Totl_c0))
22562295
outp += sprintf(outp, "%s%.2f", (printed++ ? delim : ""), 100.0 * p->pkg_wtd_core_c0 / tsc);
@@ -2437,6 +2476,15 @@ int delta_package(struct pkg_data *new, struct pkg_data *old)
24372476
old->gfx_mhz = new->gfx_mhz;
24382477
old->gfx_act_mhz = new->gfx_act_mhz;
24392478

2479+
/* flag an error when mc6 counter resets/wraps */
2480+
if (old->sam_mc6_ms > new->sam_mc6_ms)
2481+
old->sam_mc6_ms = -1;
2482+
else
2483+
old->sam_mc6_ms = new->sam_mc6_ms - old->sam_mc6_ms;
2484+
2485+
old->sam_mhz = new->sam_mhz;
2486+
old->sam_act_mhz = new->sam_act_mhz;
2487+
24402488
old->energy_pkg.raw_value = new->energy_pkg.raw_value - old->energy_pkg.raw_value;
24412489
old->energy_cores.raw_value = new->energy_cores.raw_value - old->energy_cores.raw_value;
24422490
old->energy_gfx.raw_value = new->energy_gfx.raw_value - old->energy_gfx.raw_value;
@@ -2661,6 +2709,9 @@ void clear_counters(struct thread_data *t, struct core_data *c, struct pkg_data
26612709
p->uncore_mhz = 0;
26622710
p->gfx_mhz = 0;
26632711
p->gfx_act_mhz = 0;
2712+
p->sam_mc6_ms = 0;
2713+
p->sam_mhz = 0;
2714+
p->sam_act_mhz = 0;
26642715
for (i = 0, mp = sys.tp; mp; i++, mp = mp->next)
26652716
t->counter[i] = 0;
26662717

@@ -2775,6 +2826,9 @@ int sum_counters(struct thread_data *t, struct core_data *c, struct pkg_data *p)
27752826
average.packages.uncore_mhz = p->uncore_mhz;
27762827
average.packages.gfx_mhz = p->gfx_mhz;
27772828
average.packages.gfx_act_mhz = p->gfx_act_mhz;
2829+
average.packages.sam_mc6_ms = p->sam_mc6_ms;
2830+
average.packages.sam_mhz = p->sam_mhz;
2831+
average.packages.sam_act_mhz = p->sam_act_mhz;
27782832

27792833
average.packages.pkg_temp_c = MAX(average.packages.pkg_temp_c, p->pkg_temp_c);
27802834

@@ -3572,19 +3626,28 @@ int get_counters(struct thread_data *t, struct core_data *c, struct pkg_data *p)
35723626
p->pkg_temp_c = tj_max - ((msr >> 16) & 0x7F);
35733627
}
35743628

3575-
if (DO_BIC(BIC_GFX_rc6))
3576-
p->gfx_rc6_ms = gfx_info[GFX_rc6].val_ull;
3577-
35783629
/* n.b. assume die0 uncore frequency applies to whole package */
35793630
if (DO_BIC(BIC_UNCORE_MHZ))
35803631
p->uncore_mhz = get_uncore_mhz(p->package_id, 0);
35813632

3633+
if (DO_BIC(BIC_GFX_rc6))
3634+
p->gfx_rc6_ms = gfx_info[GFX_rc6].val_ull;
3635+
35823636
if (DO_BIC(BIC_GFXMHz))
35833637
p->gfx_mhz = gfx_info[GFX_MHz].val;
35843638

35853639
if (DO_BIC(BIC_GFXACTMHz))
35863640
p->gfx_act_mhz = gfx_info[GFX_ACTMHz].val;
35873641

3642+
if (DO_BIC(BIC_SAM_mc6))
3643+
p->sam_mc6_ms = gfx_info[SAM_mc6].val_ull;
3644+
3645+
if (DO_BIC(BIC_SAMMHz))
3646+
p->sam_mhz = gfx_info[SAM_MHz].val;
3647+
3648+
if (DO_BIC(BIC_SAMACTMHz))
3649+
p->sam_act_mhz = gfx_info[SAM_ACTMHz].val;
3650+
35883651
for (i = 0, mp = sys.pp; mp; i++, mp = mp->next) {
35893652
if (get_mp(cpu, mp, &p->counter[i]))
35903653
return -10;
@@ -4634,6 +4697,7 @@ int snapshot_graphics(int idx)
46344697

46354698
switch (idx) {
46364699
case GFX_rc6:
4700+
case SAM_mc6:
46374701
fp = fopen_or_die(gfx_info[idx].path, "r");
46384702
retval = fscanf(fp, "%lld", &gfx_info[idx].val_ull);
46394703
if (retval != 1)
@@ -4642,6 +4706,8 @@ int snapshot_graphics(int idx)
46424706
return 0;
46434707
case GFX_MHz:
46444708
case GFX_ACTMHz:
4709+
case SAM_MHz:
4710+
case SAM_ACTMHz:
46454711
if (gfx_info[idx].fp == NULL) {
46464712
gfx_info[idx].fp = fopen_or_die(gfx_info[idx].path, "r");
46474713
} else {
@@ -4727,6 +4793,15 @@ int snapshot_proc_sysfs_files(void)
47274793
if (DO_BIC(BIC_GFXACTMHz))
47284794
snapshot_graphics(GFX_ACTMHz);
47294795

4796+
if (DO_BIC(BIC_SAM_mc6))
4797+
snapshot_graphics(SAM_mc6);
4798+
4799+
if (DO_BIC(BIC_SAMMHz))
4800+
snapshot_graphics(SAM_MHz);
4801+
4802+
if (DO_BIC(BIC_SAMACTMHz))
4803+
snapshot_graphics(SAM_ACTMHz);
4804+
47304805
if (DO_BIC(BIC_CPU_LPI))
47314806
snapshot_cpu_lpi_us();
47324807

@@ -5325,6 +5400,12 @@ static void probe_graphics(void)
53255400
BIC_PRESENT(BIC_GFXMHz);
53265401
if (gfx_info[GFX_ACTMHz].path)
53275402
BIC_PRESENT(BIC_GFXACTMHz);
5403+
if (gfx_info[SAM_mc6].path)
5404+
BIC_PRESENT(BIC_SAM_mc6);
5405+
if (gfx_info[SAM_MHz].path)
5406+
BIC_PRESENT(BIC_SAMMHz);
5407+
if (gfx_info[SAM_ACTMHz].path)
5408+
BIC_PRESENT(BIC_SAMACTMHz);
53285409
}
53295410

53305411
static void dump_sysfs_cstate_config(void)

0 commit comments

Comments
 (0)