Skip to content

Commit 3bd3bc2

Browse files
rfvirgilvinodkoul
authored andcommitted
soundwire: bus: Remove unused reset_page_addr() callback
A previous patch removed unnecessary zeroing of the page registers after a paged transaction, so now the reset_page_addr callback is unused and can be removed. Signed-off-by: Richard Fitzgerald <[email protected]> Reviewed-by: Pierre-Louis Bossart <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent c8a0d6b commit 3bd3bc2

File tree

4 files changed

+0
-21
lines changed

4 files changed

+0
-21
lines changed

drivers/soundwire/cadence_master.c

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -770,20 +770,6 @@ cdns_xfer_msg_defer(struct sdw_bus *bus,
770770
}
771771
EXPORT_SYMBOL(cdns_xfer_msg_defer);
772772

773-
enum sdw_command_response
774-
cdns_reset_page_addr(struct sdw_bus *bus, unsigned int dev_num)
775-
{
776-
struct sdw_cdns *cdns = bus_to_cdns(bus);
777-
struct sdw_msg msg;
778-
779-
/* Create dummy message with valid device number */
780-
memset(&msg, 0, sizeof(msg));
781-
msg.dev_num = dev_num;
782-
783-
return cdns_program_scp_addr(cdns, &msg);
784-
}
785-
EXPORT_SYMBOL(cdns_reset_page_addr);
786-
787773
u32 cdns_read_ping_status(struct sdw_bus *bus)
788774
{
789775
struct sdw_cdns *cdns = bus_to_cdns(bus);

drivers/soundwire/cadence_master.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,9 +182,6 @@ struct sdw_cdns_pdi *sdw_cdns_alloc_pdi(struct sdw_cdns *cdns,
182182
void sdw_cdns_config_stream(struct sdw_cdns *cdns,
183183
u32 ch, u32 dir, struct sdw_cdns_pdi *pdi);
184184

185-
enum sdw_command_response
186-
cdns_reset_page_addr(struct sdw_bus *bus, unsigned int dev_num);
187-
188185
enum sdw_command_response
189186
cdns_xfer_msg(struct sdw_bus *bus, struct sdw_msg *msg);
190187

drivers/soundwire/intel_auxdevice.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ static struct sdw_master_ops sdw_intel_ops = {
113113
.override_adr = sdw_dmi_override_adr,
114114
.xfer_msg = cdns_xfer_msg,
115115
.xfer_msg_defer = cdns_xfer_msg_defer,
116-
.reset_page_addr = cdns_reset_page_addr,
117116
.set_bus_conf = cdns_bus_conf,
118117
.pre_bank_switch = generic_pre_bank_switch,
119118
.post_bank_switch = generic_post_bank_switch,

include/linux/soundwire/sdw.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -838,7 +838,6 @@ struct sdw_defer {
838838
* @override_adr: Override value read from firmware (quirk for buggy firmware)
839839
* @xfer_msg: Transfer message callback
840840
* @xfer_msg_defer: Defer version of transfer message callback
841-
* @reset_page_addr: Reset the SCP page address registers
842841
* @set_bus_conf: Set the bus configuration
843842
* @pre_bank_switch: Callback for pre bank switch
844843
* @post_bank_switch: Callback for post bank switch
@@ -854,8 +853,6 @@ struct sdw_master_ops {
854853
enum sdw_command_response (*xfer_msg_defer)
855854
(struct sdw_bus *bus, struct sdw_msg *msg,
856855
struct sdw_defer *defer);
857-
enum sdw_command_response (*reset_page_addr)
858-
(struct sdw_bus *bus, unsigned int dev_num);
859856
int (*set_bus_conf)(struct sdw_bus *bus,
860857
struct sdw_bus_params *params);
861858
int (*pre_bank_switch)(struct sdw_bus *bus);

0 commit comments

Comments
 (0)