Skip to content

Commit 3c21964

Browse files
arndbvinodkoul
authored andcommitted
dmaengine: remove slave_id config field
All references to the slave_id field have been removed, so remove the field as well to prevent new references from creeping in again. Originally this allowed slave DMA drivers to configure which device is accessed with the dmaengine_slave_config() call, but this was inconsistent, as the same information is also passed while requesting a channel, and never changes in practice. In modern kernels, the device is always selected when requesting the channel, so the .slave_id field is no longer useful. Reviewed-by: Laurent Pinchart <[email protected]> Signed-off-by: Arnd Bergmann <[email protected]> Acked-by: Mark Brown <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 93cdb5b commit 3c21964

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

include/linux/dmaengine.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -418,9 +418,6 @@ enum dma_slave_buswidth {
418418
* @device_fc: Flow Controller Settings. Only valid for slave channels. Fill
419419
* with 'true' if peripheral should be flow controller. Direction will be
420420
* selected at Runtime.
421-
* @slave_id: Slave requester id. Only valid for slave channels. The dma
422-
* slave peripheral will have unique id as dma requester which need to be
423-
* pass as slave config.
424421
* @peripheral_config: peripheral configuration for programming peripheral
425422
* for dmaengine transfer
426423
* @peripheral_size: peripheral configuration buffer size
@@ -448,7 +445,6 @@ struct dma_slave_config {
448445
u32 src_port_window_size;
449446
u32 dst_port_window_size;
450447
bool device_fc;
451-
unsigned int slave_id;
452448
void *peripheral_config;
453449
size_t peripheral_size;
454450
};

0 commit comments

Comments
 (0)