Skip to content

Commit 3c9265e

Browse files
Yue Haibingmartinkpetersen
authored andcommitted
scsi: target: Remove unused declarations
Commit 1324701 ("scsi: target: iscsi: Fix hang in the iSCSI login code") removed iscsi_handle_login_thread_timeout() but left declaration. Commit 3e1c81a ("iscsi-target: Refactor RX PDU logic + export request PDU handling") left iscsi_target_get_initial_payload() declaration. Commit d703ce2 ("iscsi/iser-target: Convert to command priv_size usage") remove iscsit_alloc_cmd() but left declaration. And finally, a few other declarations were never implenmented since introduction in commit e48354c ("iscsi-target: Add iSCSI fabric support for target v4.1"). Signed-off-by: Yue Haibing <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 2e4b02f commit 3c9265e

File tree

5 files changed

+0
-15
lines changed

5 files changed

+0
-15
lines changed

drivers/target/iscsi/iscsi_target.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ struct kref;
1515
struct sockaddr_storage;
1616

1717
extern struct iscsi_tiqn *iscsit_get_tiqn_for_login(unsigned char *);
18-
extern struct iscsi_tiqn *iscsit_get_tiqn(unsigned char *, int);
1918
extern void iscsit_put_tiqn_for_login(struct iscsi_tiqn *);
2019
extern struct iscsi_tiqn *iscsit_add_tiqn(unsigned char *);
2120
extern void iscsit_del_tiqn(struct iscsi_tiqn *);
@@ -35,7 +34,6 @@ extern void iscsit_set_unsolicited_dataout(struct iscsit_cmd *);
3534
extern int iscsit_logout_closesession(struct iscsit_cmd *, struct iscsit_conn *);
3635
extern int iscsit_logout_closeconnection(struct iscsit_cmd *, struct iscsit_conn *);
3736
extern int iscsit_logout_removeconnforrecovery(struct iscsit_cmd *, struct iscsit_conn *);
38-
extern int iscsit_send_async_msg(struct iscsit_conn *, u16, u8, u8);
3937
extern int iscsit_build_r2ts_for_cmd(struct iscsit_conn *, struct iscsit_cmd *, bool recovery);
4038
extern void iscsit_thread_get_cpumask(struct iscsit_conn *);
4139
extern int iscsi_target_tx_thread(void *);

drivers/target/iscsi/iscsi_target_login.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,5 @@ extern int iscsit_start_kthreads(struct iscsit_conn *);
2424
extern void iscsi_post_login_handler(struct iscsi_np *, struct iscsit_conn *, u8);
2525
extern void iscsi_target_login_sess_out(struct iscsit_conn *, bool, bool);
2626
extern int iscsi_target_login_thread(void *);
27-
extern void iscsi_handle_login_thread_timeout(struct timer_list *t);
2827

2928
#endif /*** ISCSI_TARGET_LOGIN_H ***/

drivers/target/iscsi/iscsi_target_nego.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ extern int extract_param(const char *, const char *, unsigned int, char *,
1515
unsigned char *);
1616
extern int iscsi_target_check_login_request(struct iscsit_conn *,
1717
struct iscsi_login *);
18-
extern int iscsi_target_get_initial_payload(struct iscsit_conn *,
19-
struct iscsi_login *);
2018
extern int iscsi_target_locate_portal(struct iscsi_np *, struct iscsit_conn *,
2119
struct iscsi_login *);
2220
extern int iscsi_target_start_negotiation(

drivers/target/iscsi/iscsi_target_tpg.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,7 @@ extern int iscsit_tpg_del_portal_group(struct iscsi_tiqn *, struct iscsi_portal_
2424
int);
2525
extern int iscsit_tpg_enable_portal_group(struct iscsi_portal_group *);
2626
extern int iscsit_tpg_disable_portal_group(struct iscsi_portal_group *, int);
27-
extern struct iscsi_node_acl *iscsit_tpg_add_initiator_node_acl(
28-
struct iscsi_portal_group *, const char *, u32);
29-
extern void iscsit_tpg_del_initiator_node_acl(struct iscsi_portal_group *,
30-
struct se_node_acl *);
3127
extern struct iscsi_node_attrib *iscsit_tpg_get_node_attrib(struct iscsit_session *);
32-
extern void iscsit_tpg_del_external_nps(struct iscsi_tpg_np *);
3328
extern struct iscsi_tpg_np *iscsit_tpg_locate_child_np(struct iscsi_tpg_np *, int);
3429
extern struct iscsi_tpg_np *iscsit_tpg_add_network_portal(struct iscsi_portal_group *,
3530
struct sockaddr_storage *, struct iscsi_tpg_np *,

drivers/target/iscsi/iscsi_target_util.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ extern struct iscsi_r2t *iscsit_get_r2t_for_eos(struct iscsit_cmd *, u32, u32);
1717
extern struct iscsi_r2t *iscsit_get_r2t_from_list(struct iscsit_cmd *);
1818
extern void iscsit_free_r2t(struct iscsi_r2t *, struct iscsit_cmd *);
1919
extern void iscsit_free_r2ts_from_list(struct iscsit_cmd *);
20-
extern struct iscsit_cmd *iscsit_alloc_cmd(struct iscsit_conn *, gfp_t);
2120
extern struct iscsit_cmd *iscsit_allocate_cmd(struct iscsit_conn *, int);
2221
extern struct iscsi_seq *iscsit_get_seq_holder_for_datain(struct iscsit_cmd *, u32);
2322
extern struct iscsi_seq *iscsit_get_seq_holder_for_r2t(struct iscsit_cmd *);
@@ -34,7 +33,6 @@ extern void iscsit_add_cmd_to_immediate_queue(struct iscsit_cmd *, struct iscsit
3433
extern struct iscsi_queue_req *iscsit_get_cmd_from_immediate_queue(struct iscsit_conn *);
3534
extern int iscsit_add_cmd_to_response_queue(struct iscsit_cmd *, struct iscsit_conn *, u8);
3635
extern struct iscsi_queue_req *iscsit_get_cmd_from_response_queue(struct iscsit_conn *);
37-
extern void iscsit_remove_cmd_from_tx_queues(struct iscsit_cmd *, struct iscsit_conn *);
3836
extern bool iscsit_conn_all_queues_empty(struct iscsit_conn *);
3937
extern void iscsit_free_queue_reqs_for_conn(struct iscsit_conn *);
4038
extern void iscsit_release_cmd(struct iscsit_cmd *);
@@ -64,9 +62,6 @@ extern int iscsit_send_tx_data(struct iscsit_cmd *, struct iscsit_conn *, int);
6462
extern int iscsit_fe_sendpage_sg(struct iscsit_cmd *, struct iscsit_conn *);
6563
extern int iscsit_tx_login_rsp(struct iscsit_conn *, u8, u8);
6664
extern void iscsit_print_session_params(struct iscsit_session *);
67-
extern int iscsit_print_dev_to_proc(char *, char **, off_t, int);
68-
extern int iscsit_print_sessions_to_proc(char *, char **, off_t, int);
69-
extern int iscsit_print_tpg_to_proc(char *, char **, off_t, int);
7065
extern int rx_data(struct iscsit_conn *, struct kvec *, int, int);
7166
extern int tx_data(struct iscsit_conn *, struct kvec *, int, int);
7267
extern void iscsit_collect_login_stats(struct iscsit_conn *, u8, u8);

0 commit comments

Comments
 (0)