Skip to content

Commit 3ca11da

Browse files
Dragan Simicmmind
authored andcommitted
arm64: dts: rockchip: Delete redundant RK3328 GMAC stability fixes
Since the commit 8a469ee ("arm64: dts: rockchip: Add txpbl node for RK3399/RK3328"), having "snps,txpbl" properties defined as Ethernet stability fixes in RK3328-based board dts(i) files is redundant, because that commit added the required fix to the RK3328 SoC dtsi, so let's delete them. It has been determined that the Ethernet stability fixes no longer require "snps,rxpbl", "snps,aal" and "snps,force_thresh_dma_mode" properties, [1][2] out of which the last two also induce performance penalties, so let's delete these properties from the relevant RK3328-based board dts(i) files. This commit completes the removal of these redundant "snps,*" DT properties that was started by a patch from Peter Geis. [3] [1] https://lore.kernel.org/linux-rockchip/CAMdYzYpj3d7Rq0O0QjV4r6HEf_e07R0QAhPT2NheZdQV3TnQ6g@mail.gmail.com/ [2] https://lore.kernel.org/linux-rockchip/CAMdYzYpnx=pHJ+oqshgfZFp=Mfqp3TcMmEForqJ+s9KuhkgnqA@mail.gmail.com/ [3] https://lore.kernel.org/linux-rockchip/[email protected]/ Cc: Peter Geis <[email protected]> Acked-by: Peter Geis <[email protected]> Signed-off-by: Dragan Simic <[email protected]> Link: https://lore.kernel.org/r/fe05ecccc9fe27a678ad3e700ea022429f659724.1733943615.git.dsimic@manjaro.org Signed-off-by: Heiko Stuebner <[email protected]>
1 parent 2859e1a commit 3ca11da

File tree

5 files changed

+0
-7
lines changed

5 files changed

+0
-7
lines changed

arch/arm64/boot/dts/rockchip/rk3328-a1.dts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@
110110
phy-supply = <&vcc_io>;
111111
pinctrl-names = "default";
112112
pinctrl-0 = <&rgmiim1_pins>;
113-
snps,aal;
114113
snps,pbl = <0x4>;
115114
tx_delay = <0x26>;
116115
rx_delay = <0x11>;

arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2.dtsi

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@
142142
phy-supply = <&vcc_io_33>;
143143
pinctrl-0 = <&rgmiim1_pins>;
144144
pinctrl-names = "default";
145-
snps,aal;
146145

147146
mdio {
148147
compatible = "snps,dwmac-mdio";

arch/arm64/boot/dts/rockchip/rk3328-orangepi-r1-plus.dtsi

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@
113113
phy-supply = <&vcc_io>;
114114
pinctrl-0 = <&rgmiim1_pins>;
115115
pinctrl-names = "default";
116-
snps,aal;
117116

118117
mdio {
119118
compatible = "snps,dwmac-mdio";

arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,6 @@
153153
phy-supply = <&vcc_io>;
154154
pinctrl-names = "default";
155155
pinctrl-0 = <&rgmiim1_pins>;
156-
snps,aal;
157-
snps,rxpbl = <0x4>;
158-
snps,txpbl = <0x4>;
159156
tx_delay = <0x26>;
160157
rx_delay = <0x11>;
161158
status = "okay";

arch/arm64/boot/dts/rockchip/rk3328-rock64.dts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,6 @@
144144
phy-mode = "rgmii";
145145
pinctrl-names = "default";
146146
pinctrl-0 = <&rgmiim1_pins>;
147-
snps,force_thresh_dma_mode;
148147
snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>;
149148
snps,reset-active-low;
150149
snps,reset-delays-us = <0 10000 50000>;

0 commit comments

Comments
 (0)