Skip to content

Commit 3cfef1b

Browse files
lostjeffledhowells
authored andcommitted
netfs: fix parameter of cleanup()
The order of these two parameters is just reversed. gcc didn't warn on that, probably because 'void *' can be converted from or to other pointer types without warning. Cc: [email protected] Fixes: 3d3c950 ("netfs: Provide readahead and readpage netfs helpers") Fixes: e1b1240 ("netfs: Add write_begin helper") Signed-off-by: Jeffle Xu <[email protected]> Signed-off-by: David Howells <[email protected]> Reviewed-by: Jeff Layton <[email protected]> Link: https://lore.kernel.org/r/[email protected]/ # v1
1 parent 598ad0b commit 3cfef1b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

fs/netfs/read_helper.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -955,7 +955,7 @@ int netfs_readpage(struct file *file,
955955
rreq = netfs_alloc_read_request(ops, netfs_priv, file);
956956
if (!rreq) {
957957
if (netfs_priv)
958-
ops->cleanup(netfs_priv, folio_file_mapping(folio));
958+
ops->cleanup(folio_file_mapping(folio), netfs_priv);
959959
folio_unlock(folio);
960960
return -ENOMEM;
961961
}
@@ -1186,7 +1186,7 @@ int netfs_write_begin(struct file *file, struct address_space *mapping,
11861186
goto error;
11871187
have_folio_no_wait:
11881188
if (netfs_priv)
1189-
ops->cleanup(netfs_priv, mapping);
1189+
ops->cleanup(mapping, netfs_priv);
11901190
*_folio = folio;
11911191
_leave(" = 0");
11921192
return 0;
@@ -1197,7 +1197,7 @@ int netfs_write_begin(struct file *file, struct address_space *mapping,
11971197
folio_unlock(folio);
11981198
folio_put(folio);
11991199
if (netfs_priv)
1200-
ops->cleanup(netfs_priv, mapping);
1200+
ops->cleanup(mapping, netfs_priv);
12011201
_leave(" = %d", ret);
12021202
return ret;
12031203
}

0 commit comments

Comments
 (0)