Skip to content

Commit 3d092ef

Browse files
committed
ipmi: When handling send message responses, don't process the message
A chunk was dropped when the code handling send messages was rewritten. Those messages shouldn't be processed normally, they are just an indication that the message was successfully sent and the timers should be started for the real response that should be coming later. Add back in the missing chunk to just discard the message and go on. Fixes: 059747c ("ipmi: Add support for IPMB direct messages") Reported-by: Joe Wiese <[email protected]> Cc: [email protected] # v5.16+ Signed-off-by: Corey Minyard <[email protected]> Tested-by: Joe Wiese <[email protected]>
1 parent ae085d7 commit 3d092ef

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/char/ipmi/ipmi_msghandler.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4518,6 +4518,8 @@ static int handle_one_recv_msg(struct ipmi_smi *intf,
45184518
} else
45194519
/* The message was sent, start the timer. */
45204520
intf_start_seq_timer(intf, msg->msgid);
4521+
requeue = 0;
4522+
goto out;
45214523
} else if (((msg->rsp[0] >> 2) != ((msg->data[0] >> 2) | 1))
45224524
|| (msg->rsp[1] != msg->data[1])) {
45234525
/*

0 commit comments

Comments
 (0)