Skip to content

Commit 3d335a5

Browse files
committed
Merge tag 'drm-intel-next-2022-11-18' of git://anongit.freedesktop.org/drm/drm-intel into drm-next
GVT Changes: - gvt-next stuff mostly with refactor for the new MDEV interface. i915 Changes: - PSR fixes and improvements (Jouni) - DP DSC fixes (Vinod, Jouni) - More general display cleanups (Jani) - More display collor management cleanup targetting degamma (Ville) - remove circ_buf.h includes (Jiri) - wait power off delay at driver remove to optimize probe (Jani) - More audio cleanup targeting the ELD precompute readout (Ville) - Enable DC power states on all eDP ports (Imre) - RPL-P stepping info (Matt Atwood) - MTL enabling patches (RK) - Removal of DG2 force_probe (Matt) Signed-off-by: Dave Airlie <[email protected]> From: Rodrigo Vivi <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
2 parents 242eb7b + d2eae8e commit 3d335a5

File tree

122 files changed

+1173
-749
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

122 files changed

+1173
-749
lines changed

drivers/gpu/drm/i915/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,7 @@ i915-y += \
248248
display/intel_global_state.o \
249249
display/intel_hdcp.o \
250250
display/intel_hotplug.o \
251+
display/intel_hti.o \
251252
display/intel_lpe_audio.o \
252253
display/intel_modeset_verify.o \
253254
display/intel_modeset_setup.o \

drivers/gpu/drm/i915/display/g4x_dp.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include <linux/string_helpers.h>
99

1010
#include "g4x_dp.h"
11+
#include "i915_reg.h"
1112
#include "intel_audio.h"
1213
#include "intel_backlight.h"
1314
#include "intel_connector.h"

drivers/gpu/drm/i915/display/g4x_dp.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
#include <linux/types.h>
1010

11-
#include "i915_reg.h"
11+
#include "i915_reg_defs.h"
1212

1313
enum pipe;
1414
enum port;

drivers/gpu/drm/i915/display/g4x_hdmi.c

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
*/
77

88
#include "g4x_hdmi.h"
9+
#include "i915_reg.h"
910
#include "intel_audio.h"
1011
#include "intel_connector.h"
1112
#include "intel_crtc.h"
@@ -78,6 +79,18 @@ static bool intel_hdmi_get_hw_state(struct intel_encoder *encoder,
7879
return ret;
7980
}
8081

82+
static int g4x_hdmi_compute_config(struct intel_encoder *encoder,
83+
struct intel_crtc_state *crtc_state,
84+
struct drm_connector_state *conn_state)
85+
{
86+
struct drm_i915_private *i915 = to_i915(encoder->base.dev);
87+
88+
if (HAS_PCH_SPLIT(i915))
89+
crtc_state->has_pch_encoder = true;
90+
91+
return intel_hdmi_compute_config(encoder, crtc_state, conn_state);
92+
}
93+
8194
static void intel_hdmi_get_config(struct intel_encoder *encoder,
8295
struct intel_crtc_state *pipe_config)
8396
{
@@ -543,7 +556,7 @@ void g4x_hdmi_init(struct drm_i915_private *dev_priv,
543556
"HDMI %c", port_name(port));
544557

545558
intel_encoder->hotplug = intel_hdmi_hotplug;
546-
intel_encoder->compute_config = intel_hdmi_compute_config;
559+
intel_encoder->compute_config = g4x_hdmi_compute_config;
547560
if (HAS_PCH_SPLIT(dev_priv)) {
548561
intel_encoder->disable = pch_disable_hdmi;
549562
intel_encoder->post_disable = pch_post_disable_hdmi;

drivers/gpu/drm/i915/display/i9xx_plane.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,16 @@
88
#include <drm/drm_blend.h>
99
#include <drm/drm_fourcc.h>
1010

11+
#include "i915_irq.h"
12+
#include "i915_reg.h"
13+
#include "i9xx_plane.h"
1114
#include "intel_atomic.h"
1215
#include "intel_atomic_plane.h"
1316
#include "intel_de.h"
1417
#include "intel_display_types.h"
1518
#include "intel_fb.h"
1619
#include "intel_fbc.h"
1720
#include "intel_sprite.h"
18-
#include "i9xx_plane.h"
1921

2022
/* Primary plane formats for gen <= 3 */
2123
static const u32 i8xx_primary_formats[] = {

drivers/gpu/drm/i915/display/icl_dsi.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
#include <drm/drm_atomic_helper.h>
3030
#include <drm/drm_mipi_dsi.h>
3131

32+
#include "i915_reg.h"
3233
#include "icl_dsi.h"
3334
#include "icl_dsi_regs.h"
3435
#include "intel_atomic.h"

drivers/gpu/drm/i915/display/icl_dsi_regs.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
#ifndef __ICL_DSI_REGS_H__
77
#define __ICL_DSI_REGS_H__
88

9-
#include "i915_reg_defs.h"
9+
#include "intel_display_reg_defs.h"
1010

1111
/* Gen11 DSI */
1212
#define _MMIO_DSI(tc, dsi0, dsi1) _MMIO_TRANS((tc) - TRANSCODER_DSI_0, \

drivers/gpu/drm/i915/display/intel_atomic_plane.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -757,7 +757,7 @@ void intel_plane_update_noarm(struct intel_plane *plane,
757757
{
758758
struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
759759

760-
trace_intel_plane_update_noarm(&plane->base, crtc);
760+
trace_intel_plane_update_noarm(plane, crtc);
761761

762762
if (plane->update_noarm)
763763
plane->update_noarm(plane, crtc_state, plane_state);
@@ -769,7 +769,7 @@ void intel_plane_update_arm(struct intel_plane *plane,
769769
{
770770
struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
771771

772-
trace_intel_plane_update_arm(&plane->base, crtc);
772+
trace_intel_plane_update_arm(plane, crtc);
773773

774774
if (crtc_state->do_async_flip && plane->async_flip)
775775
plane->async_flip(plane, crtc_state, plane_state, true);
@@ -782,7 +782,7 @@ void intel_plane_disable_arm(struct intel_plane *plane,
782782
{
783783
struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
784784

785-
trace_intel_plane_disable_arm(&plane->base, crtc);
785+
trace_intel_plane_disable_arm(plane, crtc);
786786
plane->disable_arm(plane, crtc_state);
787787
}
788788

drivers/gpu/drm/i915/display/intel_audio.c

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -838,8 +838,8 @@ void intel_audio_codec_enable(struct intel_encoder *encoder,
838838

839839
if (i915->display.funcs.audio)
840840
i915->display.funcs.audio->audio_codec_enable(encoder,
841-
crtc_state,
842-
conn_state);
841+
crtc_state,
842+
conn_state);
843843

844844
mutex_lock(&i915->display.audio.mutex);
845845
encoder->audio_connector = connector;
@@ -854,7 +854,7 @@ void intel_audio_codec_enable(struct intel_encoder *encoder,
854854
if (!intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST))
855855
pipe = -1;
856856
acomp->base.audio_ops->pin_eld_notify(acomp->base.audio_ops->audio_ptr,
857-
(int) port, (int) pipe);
857+
(int)port, (int)pipe);
858858
}
859859

860860
intel_lpe_audio_notify(i915, pipe, port, connector->eld,
@@ -891,8 +891,8 @@ void intel_audio_codec_disable(struct intel_encoder *encoder,
891891

892892
if (i915->display.funcs.audio)
893893
i915->display.funcs.audio->audio_codec_disable(encoder,
894-
old_crtc_state,
895-
old_conn_state);
894+
old_crtc_state,
895+
old_conn_state);
896896

897897
mutex_lock(&i915->display.audio.mutex);
898898
encoder->audio_connector = NULL;
@@ -905,7 +905,7 @@ void intel_audio_codec_disable(struct intel_encoder *encoder,
905905
if (!intel_crtc_has_type(old_crtc_state, INTEL_OUTPUT_DP_MST))
906906
pipe = -1;
907907
acomp->base.audio_ops->pin_eld_notify(acomp->base.audio_ops->audio_ptr,
908-
(int) port, (int) pipe);
908+
(int)port, (int)pipe);
909909
}
910910

911911
intel_lpe_audio_notify(i915, pipe, port, NULL, 0, false);
@@ -1129,10 +1129,10 @@ static int i915_audio_component_get_cdclk_freq(struct device *kdev)
11291129
static struct intel_encoder *get_saved_enc(struct drm_i915_private *i915,
11301130
int port, int pipe)
11311131
{
1132-
struct intel_encoder *encoder;
1133-
11341132
/* MST */
11351133
if (pipe >= 0) {
1134+
struct intel_encoder *encoder;
1135+
11361136
if (drm_WARN_ON(&i915->drm,
11371137
pipe >= ARRAY_SIZE(i915->display.audio.encoder_map)))
11381138
return NULL;
@@ -1143,7 +1143,7 @@ static struct intel_encoder *get_saved_enc(struct drm_i915_private *i915,
11431143
* MST or not. So it will poll all the port & pipe
11441144
* combinations
11451145
*/
1146-
if (encoder != NULL && encoder->port == port &&
1146+
if (encoder && encoder->port == port &&
11471147
encoder->type == INTEL_OUTPUT_DP_MST)
11481148
return encoder;
11491149
}
@@ -1153,14 +1153,12 @@ static struct intel_encoder *get_saved_enc(struct drm_i915_private *i915,
11531153
return NULL;
11541154

11551155
for_each_pipe(i915, pipe) {
1156-
encoder = i915->display.audio.encoder_map[pipe];
1157-
if (encoder == NULL)
1158-
continue;
1156+
struct intel_encoder *encoder;
11591157

1160-
if (encoder->type == INTEL_OUTPUT_DP_MST)
1161-
continue;
1158+
encoder = i915->display.audio.encoder_map[pipe];
11621159

1163-
if (port == encoder->port)
1160+
if (encoder && encoder->port == port &&
1161+
encoder->type != INTEL_OUTPUT_DP_MST)
11641162
return encoder;
11651163
}
11661164

drivers/gpu/drm/i915/display/intel_audio_regs.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
#ifndef __INTEL_AUDIO_REGS_H__
77
#define __INTEL_AUDIO_REGS_H__
88

9-
#include "i915_reg_defs.h"
9+
#include "intel_display_reg_defs.h"
1010

1111
#define G4X_AUD_CNTL_ST _MMIO(0x620B4)
1212
#define G4X_ELD_VALID REG_BIT(14)

0 commit comments

Comments
 (0)