Skip to content

Commit 3d5c1a0

Browse files
jgross1davem330
authored andcommitted
xen/netback: fix error path of xenvif_connect_data()
xenvif_connect_data() calls module_put() in case of error. This is wrong as there is no related module_get(). Remove the superfluous module_put(). Fixes: 279f438 ("xen-netback: Don't destroy the netdev until the vif is shut down") Cc: <[email protected]> # 3.12 Signed-off-by: Juergen Gross <[email protected]> Reviewed-by: Paul Durrant <[email protected]> Reviewed-by: Wei Liu <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 580a05f commit 3d5c1a0

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/net/xen-netback/interface.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -719,7 +719,6 @@ int xenvif_connect_data(struct xenvif_queue *queue,
719719
xenvif_unmap_frontend_data_rings(queue);
720720
netif_napi_del(&queue->napi);
721721
err:
722-
module_put(THIS_MODULE);
723722
return err;
724723
}
725724

0 commit comments

Comments
 (0)