Skip to content

Commit 3d5c5fd

Browse files
committed
ALSA: hda/hdmi: Fix incorrect mutex unlock in silent_stream_disable()
The silent_stream_disable() function introduced by the commit b1a5039 ("ALSA: hda/hdmi: fix silent stream for first playback to DP") takes the per_pin->lock mutex, but it unlocks the wrong one, spec->pcm_lock, which causes a deadlock. This patch corrects it. Fixes: b1a5039 ("ALSA: hda/hdmi: fix silent stream for first playback to DP") Reported-by: Jan Alexander Steffens (heftig) <[email protected]> Cc: <[email protected]> Acked-by: Kai Vehmanen <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent a598098 commit 3d5c5fd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/pci/hda/patch_hdmi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1733,7 +1733,7 @@ static void silent_stream_disable(struct hda_codec *codec,
17331733
per_pin->silent_stream = false;
17341734

17351735
unlock_out:
1736-
mutex_unlock(&spec->pcm_lock);
1736+
mutex_unlock(&per_pin->lock);
17371737
}
17381738

17391739
/* update ELD and jack state via audio component */

0 commit comments

Comments
 (0)