Skip to content

Commit 3dc709e

Browse files
nixiaomingmpe
authored andcommitted
powerpc/85xx: Fix oops when CONFIG_FSL_PMC=n
When CONFIG_FSL_PMC is set to n, no value is assigned to cpu_up_prepare in the mpc85xx_pm_ops structure. As a result, oops is triggered in smp_85xx_start_cpu(). smp: Bringing up secondary CPUs ... kernel tried to execute user page (0) - exploit attempt? (uid: 0) BUG: Unable to handle kernel instruction fetch (NULL pointer?) Faulting instruction address: 0x00000000 Oops: Kernel access of bad area, sig: 11 [#1] ... NIP [00000000] 0x0 LR [c0021d2c] smp_85xx_kick_cpu+0xe8/0x568 Call Trace: [c1051da8] [c0021cb8] smp_85xx_kick_cpu+0x74/0x568 (unreliable) [c1051de8] [c0011460] __cpu_up+0xc0/0x228 [c1051e18] [c0031bbc] bringup_cpu+0x30/0x224 [c1051e48] [c0031f3c] cpu_up.constprop.0+0x180/0x33c [c1051e88] [c00322e8] bringup_nonboot_cpus+0x88/0xc8 [c1051eb8] [c07e67bc] smp_init+0x30/0x78 [c1051ed8] [c07d9e28] kernel_init_freeable+0x118/0x2a8 [c1051f18] [c00032d8] kernel_init+0x14/0x124 [c1051f38] [c0010278] ret_from_kernel_thread+0x14/0x1c Fixes: c45361a ("powerpc/85xx: fix timebase sync issue when CONFIG_HOTPLUG_CPU=n") Reported-by: Martin Kennedy <[email protected]> Signed-off-by: Xiaoming Ni <[email protected]> Tested-by: Martin Kennedy <[email protected]> Signed-off-by: Michael Ellerman <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 5bb60ea commit 3dc709e

File tree

1 file changed

+2
-2
lines changed
  • arch/powerpc/platforms/85xx

1 file changed

+2
-2
lines changed

arch/powerpc/platforms/85xx/smp.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ static int smp_85xx_start_cpu(int cpu)
220220
local_irq_save(flags);
221221
hard_irq_disable();
222222

223-
if (qoriq_pm_ops)
223+
if (qoriq_pm_ops && qoriq_pm_ops->cpu_up_prepare)
224224
qoriq_pm_ops->cpu_up_prepare(cpu);
225225

226226
/* if cpu is not spinning, reset it */
@@ -292,7 +292,7 @@ static int smp_85xx_kick_cpu(int nr)
292292
booting_thread_hwid = cpu_thread_in_core(nr);
293293
primary = cpu_first_thread_sibling(nr);
294294

295-
if (qoriq_pm_ops)
295+
if (qoriq_pm_ops && qoriq_pm_ops->cpu_up_prepare)
296296
qoriq_pm_ops->cpu_up_prepare(nr);
297297

298298
/*

0 commit comments

Comments
 (0)