Skip to content

Commit 3e1f888

Browse files
GustavoARSilvagregkh
authored andcommitted
staging: wfx: Use flex_array_size() helper in memcpy()
Make use of the flex_array_size() helper to calculate the size of a flexible array member within an enclosing structure. This helper offers defense-in-depth against potential integer overflows, while at the same time makes it explicitly clear that we are dealing with a flexible array member. Signed-off-by: Gustavo A. R. Silva <[email protected]> Link: https://lore.kernel.org/r/20200729233557.GA17693@embeddedor Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 051d2d0 commit 3e1f888

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/staging/wfx/hif_tx_mib.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ int hif_set_beacon_filter_table(struct wfx_vif *wvif, int tbl_len,
113113
if (!val)
114114
return -ENOMEM;
115115
val->num_of_info_elmts = cpu_to_le32(tbl_len);
116-
memcpy(val->ie_table, tbl, tbl_len * sizeof(*tbl));
116+
memcpy(val->ie_table, tbl, flex_array_size(val, ie_table, tbl_len));
117117
ret = hif_write_mib(wvif->wdev, wvif->id,
118118
HIF_MIB_ID_BEACON_FILTER_TABLE, val, buf_len);
119119
kfree(val);

0 commit comments

Comments
 (0)