Skip to content

Commit 3e2dc6b

Browse files
takaswietiwai
authored andcommitted
ALSA: dice: fix fallback from protocol extension into limited functionality
At failure of attempt to detect protocol extension, ALSA dice driver should be fallback to limited functionality. However it's not. This commit fixes it. Cc: <[email protected]> # v4.18+ Fixes: 58579c0 ("ALSA: dice: use extended protocol to detect available stream formats") Signed-off-by: Takashi Sakamoto <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 747d1f0 commit 3e2dc6b

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

sound/firewire/dice/dice-extension.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,11 @@ int snd_dice_detect_extension_formats(struct snd_dice *dice)
159159
int j;
160160

161161
for (j = i + 1; j < 9; ++j) {
162-
if (pointers[i * 2] == pointers[j * 2])
162+
if (pointers[i * 2] == pointers[j * 2]) {
163+
// Fallback to limited functionality.
164+
err = -ENXIO;
163165
goto end;
166+
}
164167
}
165168
}
166169

0 commit comments

Comments
 (0)