Skip to content

Commit 3e5f39e

Browse files
Lai Jiangshanhtejun
authored andcommitted
workqueue: Remove the advanced kicking of the idle workers in rebind_workers()
The commit 6d25be5 ("sched/core, workqueues: Distangle worker accounting from rq lock") changed the schedule callbacks for workqueue and removed the local-wake-up functionality. Now the wakingup of workers is done by normal fashion and workers not yet migrated to the specific CPU in concurrency managed pool can also be woken up by workers that already bound to the specific cpu now. So this advanced kicking of the idle workers to migrate them to the associated CPU is unneeded now. Signed-off-by: Lai Jiangshan <[email protected]> Signed-off-by: Tejun Heo <[email protected]>
1 parent ccf4515 commit 3e5f39e

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

kernel/workqueue.c

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5057,17 +5057,6 @@ static void rebind_workers(struct worker_pool *pool)
50575057
for_each_pool_worker(worker, pool) {
50585058
unsigned int worker_flags = worker->flags;
50595059

5060-
/*
5061-
* A bound idle worker should actually be on the runqueue
5062-
* of the associated CPU for local wake-ups targeting it to
5063-
* work. Kick all idle workers so that they migrate to the
5064-
* associated CPU. Doing this in the same loop as
5065-
* replacing UNBOUND with REBOUND is safe as no worker will
5066-
* be bound before @pool->lock is released.
5067-
*/
5068-
if (worker_flags & WORKER_IDLE)
5069-
wake_up_process(worker->task);
5070-
50715060
/*
50725061
* We want to clear UNBOUND but can't directly call
50735062
* worker_clr_flags() or adjust nr_running. Atomically

0 commit comments

Comments
 (0)