vfs: make vfs_tmpfile() static

Miklos Szeredi · Miklos Szeredi · commit 3e9d4c593558 · 2022-09-24T07:00:00.000+02:00
No callers outside of fs/namei.c anymore.

Reviewed-by: Christian Brauner (Microsoft) &lt;brauner@kernel.org&gt;
Signed-off-by: Miklos Szeredi &lt;mszeredi@redhat.com&gt;
diff --git a/fs/namei.c b/fs/namei.c
@@ -3583,7 +3583,7 @@ static int do_open(struct nameidata *nd,
  * On non-idmapped mounts or if permission checking is to be performed on the
  * raw inode simply passs init_user_ns.
  */
-struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns,
+static struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns,
 			   struct dentry *dentry, umode_t mode, int open_flag)
 {
 	struct dentry *child = NULL;
@@ -3622,7 +3622,6 @@ struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns,
 	dput(child);
 	return ERR_PTR(error);
 }
-EXPORT_SYMBOL(vfs_tmpfile);
 
 /**
  * vfs_tmpfile_open - open a tmpfile for kernel internal use
diff --git a/include/linux/fs.h b/include/linux/fs.h
@@ -2004,9 +2004,6 @@ static inline int vfs_whiteout(struct user_namespace *mnt_userns,
 			 WHITEOUT_DEV);
 }
 
-struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns,
-			   struct dentry *dentry, umode_t mode, int open_flag);
-
 struct file *vfs_tmpfile_open(struct user_namespace *mnt_userns,
 			const struct path *parentpath,
 			umode_t mode, int open_flag, const struct cred *cred);

Original file line number	Diff line number	Diff line change
`@@ -2004,9 +2004,6 @@ static inline int vfs_whiteout(struct user_namespace *mnt_userns,`
`2004`	`2004`	`WHITEOUT_DEV);`
`2005`	`2005`	`}`
`2006`	`2006`
`2007`		`-struct dentry vfs_tmpfile(struct user_namespace mnt_userns,`
`2008`		`- struct dentry *dentry, umode_t mode, int open_flag);`
`2009`		`-`
`2010`	`2007`	`struct file vfs_tmpfile_open(struct user_namespace mnt_userns,`
`2011`	`2008`	`const struct path *parentpath,`
`2012`	`2009`	`umode_t mode, int open_flag, const struct cred *cred);`