Skip to content

Commit 3eae4a9

Browse files
Jinjie Ruanbroonie
authored andcommitted
spi: spi-cadence: Fix missing spi_controller_is_target() check
The spi_controller_is_target() check is missing for pm_runtime_disable() in cdns_spi_remove(), add it. Fixes: b1b9051 ("spi: spi-cadence: Add support for Slave mode") Signed-off-by: Jinjie Ruan <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 67d4a70 commit 3eae4a9

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/spi/spi-cadence.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -701,8 +701,10 @@ static void cdns_spi_remove(struct platform_device *pdev)
701701

702702
cdns_spi_write(xspi, CDNS_SPI_ER, CDNS_SPI_ER_DISABLE);
703703

704-
pm_runtime_disable(&pdev->dev);
705-
pm_runtime_set_suspended(&pdev->dev);
704+
if (!spi_controller_is_target(ctlr)) {
705+
pm_runtime_disable(&pdev->dev);
706+
pm_runtime_set_suspended(&pdev->dev);
707+
}
706708

707709
spi_unregister_controller(ctlr);
708710
}

0 commit comments

Comments
 (0)