rtc: class: remove redundant assignment to variable err

Colin Ian King · alexandrebelloni · commit 3edf29d9d585 · 2020-04-02T18:47:30.000+02:00
The variable err is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <colin.king@canonical.com> Link: https://lore.kernel.org/r/20200402110411.508534-1-colin.king@canonical.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c
@@ -48,7 +48,7 @@ int rtc_hctosys_ret = -ENODEV;
 
 static void rtc_hctosys(struct rtc_device *rtc)
 {
-	int err = -ENODEV;
+	int err;
 	struct rtc_time tm;
 	struct timespec64 tv64 = {
 		.tv_nsec = NSEC_PER_SEC >> 1,

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ int rtc_hctosys_ret = -ENODEV;`
`48`	`48`
`49`	`49`	`static void rtc_hctosys(struct rtc_device *rtc)`
`50`	`50`	`{`
`51`		`- int err = -ENODEV;`
	`51`	`+ int err;`
`52`	`52`	`struct rtc_time tm;`
`53`	`53`	`struct timespec64 tv64 = {`
`54`	`54`	`.tv_nsec = NSEC_PER_SEC >> 1,`