Skip to content

Commit 3ee339e

Browse files
lunndavem330
authored andcommitted
net: dsa: mv88e6xxx: Fix masking of egress port
Add missing ~ to the usage of the mask. Reported-by: Kevin Benson <[email protected]> Reported-by: Chris Healy <[email protected]> Fixes: 5c74c54 ("net: dsa: mv88e6xxx: Split monitor port configuration") Signed-off-by: Andrew Lunn <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent ac004e8 commit 3ee339e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/dsa/mv88e6xxx/global1.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,13 +278,13 @@ int mv88e6095_g1_set_egress_port(struct mv88e6xxx_chip *chip,
278278
switch (direction) {
279279
case MV88E6XXX_EGRESS_DIR_INGRESS:
280280
dest_port_chip = &chip->ingress_dest_port;
281-
reg &= MV88E6185_G1_MONITOR_CTL_INGRESS_DEST_MASK;
281+
reg &= ~MV88E6185_G1_MONITOR_CTL_INGRESS_DEST_MASK;
282282
reg |= port <<
283283
__bf_shf(MV88E6185_G1_MONITOR_CTL_INGRESS_DEST_MASK);
284284
break;
285285
case MV88E6XXX_EGRESS_DIR_EGRESS:
286286
dest_port_chip = &chip->egress_dest_port;
287-
reg &= MV88E6185_G1_MONITOR_CTL_EGRESS_DEST_MASK;
287+
reg &= ~MV88E6185_G1_MONITOR_CTL_EGRESS_DEST_MASK;
288288
reg |= port <<
289289
__bf_shf(MV88E6185_G1_MONITOR_CTL_EGRESS_DEST_MASK);
290290
break;

0 commit comments

Comments
 (0)