Skip to content

Commit 3eede0f

Browse files
crojewsk-intelbroonie
authored andcommitted
ASoC: Intel: avs: Adjust DSP status register names
Both status and error are "codes". Update the wording to make code cohesive. Signed-off-by: Cezary Rojewski <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent aea305d commit 3eede0f

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

sound/soc/intel/avs/loader.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ int avs_cldma_load_basefw(struct avs_dev *adev, struct firmware *fw)
168168
AVS_ROM_INIT_POLLING_US, SKL_ROM_INIT_TIMEOUT_US);
169169
if (ret < 0) {
170170
dev_err(adev->dev, "rom init failed: %d, status: 0x%08x, lec: 0x%08x\n",
171-
ret, reg, snd_hdac_adsp_readl(adev, AVS_FW_REG_ERROR_CODE(adev)));
171+
ret, reg, snd_hdac_adsp_readl(adev, AVS_FW_REG_ERROR(adev)));
172172
avs_dsp_core_disable(adev, AVS_MAIN_CORE_MASK);
173173
return ret;
174174
}
@@ -182,7 +182,7 @@ int avs_cldma_load_basefw(struct avs_dev *adev, struct firmware *fw)
182182
hda_cldma_stop(cl);
183183
if (ret < 0) {
184184
dev_err(adev->dev, "transfer fw failed: %d, status: 0x%08x, lec: 0x%08x\n",
185-
ret, reg, snd_hdac_adsp_readl(adev, AVS_FW_REG_ERROR_CODE(adev)));
185+
ret, reg, snd_hdac_adsp_readl(adev, AVS_FW_REG_ERROR(adev)));
186186
avs_dsp_core_disable(adev, AVS_MAIN_CORE_MASK);
187187
return ret;
188188
}
@@ -316,7 +316,7 @@ avs_hda_init_rom(struct avs_dev *adev, unsigned int dma_id, bool purge)
316316
AVS_ROM_INIT_POLLING_US, APL_ROM_INIT_TIMEOUT_US);
317317
if (ret < 0) {
318318
dev_err(adev->dev, "rom init failed: %d, status: 0x%08x, lec: 0x%08x\n",
319-
ret, reg, snd_hdac_adsp_readl(adev, AVS_FW_REG_ERROR_CODE(adev)));
319+
ret, reg, snd_hdac_adsp_readl(adev, AVS_FW_REG_ERROR(adev)));
320320
goto err;
321321
}
322322

@@ -348,7 +348,7 @@ static int avs_imr_load_basefw(struct avs_dev *adev)
348348
if (!ret) {
349349
dev_err(adev->dev, "firmware ready timeout, status: 0x%08x, lec: 0x%08x\n",
350350
snd_hdac_adsp_readl(adev, AVS_FW_REG_STATUS(adev)),
351-
snd_hdac_adsp_readl(adev, AVS_FW_REG_ERROR_CODE(adev)));
351+
snd_hdac_adsp_readl(adev, AVS_FW_REG_ERROR(adev)));
352352
avs_dsp_core_disable(adev, AVS_MAIN_CORE_MASK);
353353
return -ETIMEDOUT;
354354
}
@@ -408,7 +408,7 @@ int avs_hda_load_basefw(struct avs_dev *adev, struct firmware *fw)
408408
snd_hdac_dsp_trigger(hstream, false);
409409
if (ret < 0) {
410410
dev_err(adev->dev, "transfer fw failed: %d, status: 0x%08x, lec: 0x%08x\n",
411-
ret, reg, snd_hdac_adsp_readl(adev, AVS_FW_REG_ERROR_CODE(adev)));
411+
ret, reg, snd_hdac_adsp_readl(adev, AVS_FW_REG_ERROR(adev)));
412412
avs_dsp_core_disable(adev, AVS_MAIN_CORE_MASK);
413413
}
414414

@@ -590,7 +590,7 @@ static int avs_dsp_load_basefw(struct avs_dev *adev)
590590
if (!ret) {
591591
dev_err(adev->dev, "firmware ready timeout, status: 0x%08x, lec: 0x%08x\n",
592592
snd_hdac_adsp_readl(adev, AVS_FW_REG_STATUS(adev)),
593-
snd_hdac_adsp_readl(adev, AVS_FW_REG_ERROR_CODE(adev)));
593+
snd_hdac_adsp_readl(adev, AVS_FW_REG_ERROR(adev)));
594594
avs_dsp_core_disable(adev, AVS_MAIN_CORE_MASK);
595595
ret = -ETIMEDOUT;
596596
goto release_fw;

sound/soc/intel/avs/registers.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
/* Constants used when accessing SRAM, space shared with firmware */
7575
#define AVS_FW_REG_BASE(adev) ((adev)->spec->sram->base_offset)
7676
#define AVS_FW_REG_STATUS(adev) (AVS_FW_REG_BASE(adev) + 0x0)
77-
#define AVS_FW_REG_ERROR_CODE(adev) (AVS_FW_REG_BASE(adev) + 0x4)
77+
#define AVS_FW_REG_ERROR(adev) (AVS_FW_REG_BASE(adev) + 0x4)
7878

7979
#define AVS_WINDOW_CHUNK_SIZE SZ_4K
8080
#define AVS_FW_REGS_SIZE AVS_WINDOW_CHUNK_SIZE

0 commit comments

Comments
 (0)