Skip to content

Commit 3f31f7d

Browse files
jwrdegoedebroonie
authored andcommitted
ASoC: rt5670: Fix dac- and adc- vol-tlv values being off by a factor of 10
The adc_vol_tlv volume-control has a range from -17.625 dB to +30 dB, not -176.25 dB to + 300 dB. This wrong scale is esp. a problem in userspace apps which translate the dB scale to a linear scale. With the logarithmic dB scale being of by a factor of 10 we loose all precision in the lower area of the range when apps translate things to a linear scale. E.g. the 0 dB default, which corresponds with a value of 47 of the 0 - 127 range for the control, would be shown as 0/100 in alsa-mixer. Since the centi-dB values used in the TLV struct cannot represent the 0.375 dB step size used by these controls, change the TLV definition for them to specify a min and max value instead of min + stepsize. Signed-off-by: Hans de Goede <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 85ca6b1 commit 3f31f7d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

sound/soc/codecs/rt5670.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -603,9 +603,9 @@ int rt5670_set_jack_detect(struct snd_soc_component *component,
603603
EXPORT_SYMBOL_GPL(rt5670_set_jack_detect);
604604

605605
static const DECLARE_TLV_DB_SCALE(out_vol_tlv, -4650, 150, 0);
606-
static const DECLARE_TLV_DB_SCALE(dac_vol_tlv, -65625, 375, 0);
606+
static const DECLARE_TLV_DB_MINMAX(dac_vol_tlv, -6562, 0);
607607
static const DECLARE_TLV_DB_SCALE(in_vol_tlv, -3450, 150, 0);
608-
static const DECLARE_TLV_DB_SCALE(adc_vol_tlv, -17625, 375, 0);
608+
static const DECLARE_TLV_DB_MINMAX(adc_vol_tlv, -1762, 3000);
609609
static const DECLARE_TLV_DB_SCALE(adc_bst_tlv, 0, 1200, 0);
610610

611611
/* {0, +20, +24, +30, +35, +40, +44, +50, +52} dB */

0 commit comments

Comments
 (0)