Skip to content

Commit 3f37fdc

Browse files
Lee Jonesbentiss
authored andcommitted
HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote abuses
Fixes the following W=1 kernel build warning(s): drivers/hid/hid-logitech-hidpp.c:275: warning: Function parameter or member 'hidpp' not described in 'hidpp_send_message_sync' drivers/hid/hid-logitech-hidpp.c:275: warning: Function parameter or member 'message' not described in 'hidpp_send_message_sync' drivers/hid/hid-logitech-hidpp.c:275: warning: Function parameter or member 'response' not described in 'hidpp_send_message_sync' drivers/hid/hid-logitech-hidpp.c:275: warning: expecting prototype for and something else(). Prototype was for hidpp_send_message_sync() instead drivers/hid/hid-logitech-hidpp.c:427: warning: wrong kernel-doc identifier on line: drivers/hid/hid-logitech-hidpp.c:470: warning: Function parameter or member 'input_dev' not described in 'hidpp_scroll_counter_handle_scroll' drivers/hid/hid-logitech-hidpp.c:1894: warning: Function parameter or member 'hidpp' not described in 'hidpp_touchpad_fw_items_set' drivers/hid/hid-logitech-hidpp.c:1894: warning: Function parameter or member 'feature_index' not described in 'hidpp_touchpad_fw_items_set' drivers/hid/hid-logitech-hidpp.c:1894: warning: Function parameter or member 'items' not described in 'hidpp_touchpad_fw_items_set' drivers/hid/hid-logitech-hidpp.c:1894: warning: expecting prototype for send a set state command to the device by reading the current items(). Prototype was for hidpp_touchpad_fw_items_set() instead Cc: Jiri Kosina <[email protected]> Cc: Benjamin Tissoires <[email protected]> Cc: Henrik Rydberg <[email protected]> Cc: Lopez Casado <[email protected]> Cc: [email protected] Signed-off-by: Lee Jones <[email protected]> Signed-off-by: Benjamin Tissoires <[email protected]>
1 parent ae71db0 commit 3f37fdc

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

drivers/hid/hid-logitech-hidpp.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ static int __hidpp_send_report(struct hid_device *hdev,
261261
return ret == fields_count ? 0 : -1;
262262
}
263263

264-
/**
264+
/*
265265
* hidpp_send_message_sync() returns 0 in case of success, and something else
266266
* in case of a failure.
267267
* - If ' something else' is positive, that means that an error has been raised
@@ -423,7 +423,7 @@ static inline bool hidpp_report_is_connect_event(struct hidpp_device *hidpp,
423423
(report->rap.sub_id == 0x41));
424424
}
425425

426-
/**
426+
/*
427427
* hidpp_prefix_name() prefixes the current given name with "Logitech ".
428428
*/
429429
static void hidpp_prefix_name(char **name, int name_length)
@@ -454,6 +454,7 @@ static void hidpp_prefix_name(char **name, int name_length)
454454
* hidpp_scroll_counter_handle_scroll() - Send high- and low-resolution scroll
455455
* events given a high-resolution wheel
456456
* movement.
457+
* @input_dev: Pointer to the input device
457458
* @counter: a hid_scroll_counter struct describing the wheel.
458459
* @hi_res_value: the movement of the wheel, in the mouse's high-resolution
459460
* units.
@@ -1884,7 +1885,7 @@ struct hidpp_touchpad_fw_items {
18841885
uint8_t persistent;
18851886
};
18861887

1887-
/**
1888+
/*
18881889
* send a set state command to the device by reading the current items->state
18891890
* field. items is then filled with the current state.
18901891
*/

0 commit comments

Comments
 (0)