Skip to content

Commit 3fb5c90

Browse files
Yang Yinglianglinusw
authored andcommitted
pinctrl: zynqmp: Drop pinctrl_unregister for devm_ registered device
It's not necessary to unregister pin controller device registered with devm_pinctrl_register() and using pinctrl_unregister() leads to a double free. Fixes: fa99e70 ("pinctrl: zynqmp: some code cleanups") Signed-off-by: Yang Yingliang <[email protected]> Reviewed-by: Michal Simek <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Linus Walleij <[email protected]>
1 parent f03f5c7 commit 3fb5c90

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

drivers/pinctrl/pinctrl-zynqmp.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -866,15 +866,6 @@ static int zynqmp_pinctrl_probe(struct platform_device *pdev)
866866
return ret;
867867
}
868868

869-
static int zynqmp_pinctrl_remove(struct platform_device *pdev)
870-
{
871-
struct zynqmp_pinctrl *pctrl = platform_get_drvdata(pdev);
872-
873-
pinctrl_unregister(pctrl->pctrl);
874-
875-
return 0;
876-
}
877-
878869
static const struct of_device_id zynqmp_pinctrl_of_match[] = {
879870
{ .compatible = "xlnx,zynqmp-pinctrl" },
880871
{ }
@@ -887,7 +878,6 @@ static struct platform_driver zynqmp_pinctrl_driver = {
887878
.of_match_table = zynqmp_pinctrl_of_match,
888879
},
889880
.probe = zynqmp_pinctrl_probe,
890-
.remove = zynqmp_pinctrl_remove,
891881
};
892882
module_platform_driver(zynqmp_pinctrl_driver);
893883

0 commit comments

Comments
 (0)