Skip to content

Commit 3fd2fdb

Browse files
committed
mmc: meson-mx-sdio: Depend on OF_ADDRESS and not just OF
Making COMMON_CLK a visible option causes the sparc allyesconfig to fail to build like so: sparc64-linux-ld: drivers/mmc/host/meson-mx-sdio.o: in function `meson_mx_mmc_remove': meson-mx-sdio.c:(.text+0x70): undefined reference to `of_platform_device_destroy' sparc64-linux-ld: drivers/mmc/host/meson-mx-sdio.o: in function `meson_mx_mmc_probe': meson-mx-sdio.c:(.text+0x9e4): undefined reference to `of_platform_device_create' sparc64-linux-ld: meson-mx-sdio.c:(.text+0xdd4): undefined reference to `of_platform_device_destroy' This is because the implementation of of_platform_device_destroy() is inside an #ifdef CONFIG_OF_ADDRESS section of drivers/of/platform.c. This driver already depends on OF being enabled, so let's tighten that constrain a little more so that it depends on OF_ADDRESS instead. This way we won't try to build this driver on platforms that don't have this function. Reported-by: kbuild test robot <[email protected]> Cc: Neil Armstrong <[email protected]> Cc: Ulf Hansson <[email protected]> Signed-off-by: Stephen Boyd <[email protected]> Link: https://lkml.kernel.org/r/[email protected] Acked-by: Ulf Hansson <[email protected]> Reviewed-by: Arnd Bergmann <[email protected]>
1 parent b62bc04 commit 3fd2fdb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/mmc/host/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ config MMC_MESON_MX_SDIO
409409
tristate "Amlogic Meson6/Meson8/Meson8b SD/MMC Host Controller support"
410410
depends on ARCH_MESON || COMPILE_TEST
411411
depends on COMMON_CLK
412-
depends on OF
412+
depends on OF_ADDRESS
413413
help
414414
This selects support for the SD/MMC Host Controller on
415415
Amlogic Meson6, Meson8 and Meson8b SoCs.

0 commit comments

Comments
 (0)