Skip to content

Commit 3fe2ec5

Browse files
morimotowsakernel
authored andcommitted
i2c: rcar: fix PM ref counts in probe error paths
We have to take care of ID_P_PM_BLOCKED when bailing out during probe. Fixes: 7ee24eb ("i2c: rcar: disable PM in multi-master mode") Signed-off-by: Kuninori Morimoto <[email protected]> Signed-off-by: Wolfram Sang <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent e5222d4 commit 3fe2ec5

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

drivers/i2c/busses/i2c-rcar.c

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1086,8 +1086,10 @@ static int rcar_i2c_probe(struct platform_device *pdev)
10861086
pm_runtime_enable(dev);
10871087
pm_runtime_get_sync(dev);
10881088
ret = rcar_i2c_clock_calculate(priv);
1089-
if (ret < 0)
1090-
goto out_pm_put;
1089+
if (ret < 0) {
1090+
pm_runtime_put(dev);
1091+
goto out_pm_disable;
1092+
}
10911093

10921094
rcar_i2c_write(priv, ICSAR, 0); /* Gen2: must be 0 if not using slave */
10931095

@@ -1116,19 +1118,19 @@ static int rcar_i2c_probe(struct platform_device *pdev)
11161118

11171119
ret = platform_get_irq(pdev, 0);
11181120
if (ret < 0)
1119-
goto out_pm_disable;
1121+
goto out_pm_put;
11201122
priv->irq = ret;
11211123
ret = devm_request_irq(dev, priv->irq, irqhandler, irqflags, dev_name(dev), priv);
11221124
if (ret < 0) {
11231125
dev_err(dev, "cannot get irq %d\n", priv->irq);
1124-
goto out_pm_disable;
1126+
goto out_pm_put;
11251127
}
11261128

11271129
platform_set_drvdata(pdev, priv);
11281130

11291131
ret = i2c_add_numbered_adapter(adap);
11301132
if (ret < 0)
1131-
goto out_pm_disable;
1133+
goto out_pm_put;
11321134

11331135
if (priv->flags & ID_P_HOST_NOTIFY) {
11341136
priv->host_notify_client = i2c_new_slave_host_notify_device(adap);
@@ -1145,7 +1147,8 @@ static int rcar_i2c_probe(struct platform_device *pdev)
11451147
out_del_device:
11461148
i2c_del_adapter(&priv->adap);
11471149
out_pm_put:
1148-
pm_runtime_put(dev);
1150+
if (priv->flags & ID_P_PM_BLOCKED)
1151+
pm_runtime_put(dev);
11491152
out_pm_disable:
11501153
pm_runtime_disable(dev);
11511154
return ret;

0 commit comments

Comments
 (0)