Skip to content

Commit 4010cb1

Browse files
committed
firewire: core: update documentation of kernel APIs for flushing completions
There is a slight difference between fw_iso_context_flush_completions() and fw_iso_context_schedule_flush_completions(). This commit updates the documentations for them. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Sakamoto <[email protected]>
1 parent 5d56765 commit 4010cb1

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

drivers/firewire/core-iso.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -214,9 +214,12 @@ EXPORT_SYMBOL(fw_iso_context_queue_flush);
214214
* @ctx: the isochronous context
215215
*
216216
* Process the isochronous context in the current process context. The registered callback function
217-
* is called if some packets have been already transferred since the last time. If it is required
218-
* to process the context asynchronously, fw_iso_context_schedule_flush_completions() is available
219-
* instead.
217+
* is called when a queued packet buffer with the interrupt flag is completed, either after
218+
* transmission in the IT context or after being filled in the IR context. Additionally, the
219+
* callback function is also called for the packet buffer completed at last. Furthermore, the
220+
* callback function is called as well when the header buffer in the context becomes full. If it is
221+
* required to process the context asynchronously, fw_iso_context_schedule_flush_completions() is
222+
* available instead.
220223
*
221224
* Context: Process context. May sleep due to disable_work_sync().
222225
*/

include/linux/firewire.h

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -537,9 +537,11 @@ int fw_iso_context_flush_completions(struct fw_iso_context *ctx);
537537
* @ctx: the isochronous context
538538
*
539539
* Schedule a work item on workqueue to process the isochronous context. The registered callback
540-
* function is called in the worker if some packets have been already transferred since the last
541-
* time. If it is required to process the context in the current context,
542-
* fw_iso_context_flush_completions() is available instead.
540+
* function is called by the worker when a queued packet buffer with the interrupt flag is
541+
* completed, either after transmission in the IT context or after being filled in the IR context.
542+
* The callback function is also called when the header buffer in the context becomes full, If it
543+
* is required to process the context in the current context, fw_iso_context_flush_completions() is
544+
* available instead.
543545
*
544546
* Context: Any context.
545547
*/

0 commit comments

Comments
 (0)