Skip to content

Commit 4022d80

Browse files
madalinbucurdavem330
authored andcommitted
arm64: dts: ls1043a-rdb: correct RGMII delay mode to rgmii-id
The correct setting for the RGMII ports on LS1043ARDB is to enable delay on both Rx and Tx so the interface mode used must be PHY_INTERFACE_MODE_RGMII_ID. Since commit 1b3047b ("net: phy: realtek: add support for configuring the RX delay on RTL8211F") the Realtek 8211F PHY driver has control over the RGMII RX delay and it is disabling it for RGMII_TXID. The LS1043ARDB uses two such PHYs in RGMII_ID mode but in the device tree the mode was described as "rgmii_txid". This issue was not apparent at the time as the PHY driver took the same action for RGMII_TXID and RGMII_ID back then but it became visible (RX no longer working) after the above patch. Changing the phy-connection-type to "rgmii-id" to address the issue. Fixes: bf02f2f ("arm64: dts: add LS1043A DPAA FMan support") Signed-off-by: Madalin Bucur <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 0fe1568 commit 4022d80

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,12 @@
119119

120120
ethernet@e4000 {
121121
phy-handle = <&rgmii_phy1>;
122-
phy-connection-type = "rgmii-txid";
122+
phy-connection-type = "rgmii-id";
123123
};
124124

125125
ethernet@e6000 {
126126
phy-handle = <&rgmii_phy2>;
127-
phy-connection-type = "rgmii-txid";
127+
phy-connection-type = "rgmii-id";
128128
};
129129

130130
ethernet@e8000 {

0 commit comments

Comments
 (0)