Skip to content

Commit 40efb09

Browse files
Navidemthomashvmw
authored andcommitted
drm/vmwgfx: prevent memory leak in vmw_cmdbuf_res_add
In vmw_cmdbuf_res_add if drm_ht_insert_item fails the allocated memory for cres should be released. Fixes: 18e4a46 ("drm/vmwgfx: Fix compat shader namespace") Signed-off-by: Navid Emamdoost <[email protected]> Reviewed-by: Thomas Hellstrom <[email protected]> Signed-off-by: Thomas Hellstrom <[email protected]>
1 parent 0d4c19f commit 40efb09

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,8 +209,10 @@ int vmw_cmdbuf_res_add(struct vmw_cmdbuf_res_manager *man,
209209

210210
cres->hash.key = user_key | (res_type << 24);
211211
ret = drm_ht_insert_item(&man->resources, &cres->hash);
212-
if (unlikely(ret != 0))
212+
if (unlikely(ret != 0)) {
213+
kfree(cres);
213214
goto out_invalid_key;
215+
}
214216

215217
cres->state = VMW_CMDBUF_RES_ADD;
216218
cres->res = vmw_resource_reference(res);

0 commit comments

Comments
 (0)