Skip to content

Commit 40f2432

Browse files
bentissJiri Kosina
authored andcommitted
Revert "HID: logitech-hidpp: Remove special-casing of Bluetooth devices"
This reverts commit 8544c81. We need to revert commit 532223c ("HID: logitech-hidpp: Enable HID++ for all the Logitech Bluetooth devices") because that commit might make hid-logitech-hidpp bind on mice that are not well enough supported by hid-logitech-hidpp, and the end result is that the probe of those mice is now returning -ENODEV, leaving the end user with a dead mouse. Given that commit 8544c81 ("HID: logitech-hidpp: Remove special-casing of Bluetooth devices") is a direct dependency of 532223c, revert it too. Note that this also adapt according to commit 908d325 ("HID: logitech-hidpp: Detect hi-res scrolling support") to re-add support of the devices that were removed from that commit too. I have locally an MX Master and I tested this device with that revert, ensuring we still have high-res scrolling. Reported-by: Rafael J . Wysocki <[email protected]> Signed-off-by: Benjamin Tissoires <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent f6d910a commit 40f2432

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

drivers/hid/hid-logitech-hidpp.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4367,6 +4367,15 @@ static const struct hid_device_id hidpp_devices[] = {
43674367
{ /* MX5500 keyboard over Bluetooth */
43684368
HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb30b),
43694369
.driver_data = HIDPP_QUIRK_HIDPP_CONSUMER_VENDOR_KEYS },
4370+
{ /* M-RCQ142 V470 Cordless Laser Mouse over Bluetooth */
4371+
HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb008) },
4372+
{ /* MX Master mouse over Bluetooth */
4373+
HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb012) },
4374+
{ /* MX Ergo trackball over Bluetooth */
4375+
HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb01d) },
4376+
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb01e) },
4377+
{ /* MX Master 3 mouse over Bluetooth */
4378+
HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb023) },
43704379

43714380
{ /* And try to enable HID++ for all the Logitech Bluetooth devices */
43724381
HID_DEVICE(BUS_BLUETOOTH, HID_GROUP_ANY, USB_VENDOR_ID_LOGITECH, HID_ANY_ID) },

0 commit comments

Comments
 (0)